aarch64 support is not correct in the Makefile #155

kaissi · 2020-10-30T01:49:15Z

The aarch64 support is not correct in the Makefile.

Line 28 in 9ce2e80

    
           mkdir -p dist/linux/aarch64 && GOOS=linux GOARCH=aarch64 go build -ldflags "$(LDFLAGS)" -o dist/linux/aarch64/dockerize

dockerize/Makefile

Line 39 in 9ce2e80

tar -cvzf dockerize-linux-aarch64-$(TAG).tar.gz -C dist/linux/aarch64 dockerize

The aarch64 value in these two lines should be arm64. The aarch64 value is not a valid GOARCH value. Trying to execute make dist will get an error.

A practical example is making a multi-platform build of a Dockerfile using arm64 and aarch64 values:

All these Dockerfile arguments are automatically filled when using BuildKit. Also, remember to put your user in ${DOCKER_USER}.

FROM alpine

ARG TARGETPLATFORM
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT

ENV TARGETPLATFORM="${TARGETPLATFORM}" \
    TARGETOS="${TARGETOS}" \
    TARGETARCH="${TARGETARCH}" \
    TARGETVARIANT="${TARGETVARIANT}"

RUN echo "\
TARGETPLATFORM='${TARGETPLATFORM}' \
TARGETOS='${TARGETOS}' \
TARGETARCH='${TARGETARCH}' \
TARGETVARIANT='${TARGETVARIANT}'"

ENTRYPOINT echo "($(uname -m)) \
TARGETPLATFORM='${TARGETPLATFORM}' \
TARGETOS='${TARGETOS}' \
TARGETARCH='${TARGETARCH}' \
TARGETVARIANT='${TARGETVARIANT}'"

docker buildx build \
  --pull \
  --push \
  --tag ${DOCKER_USER}/buildx-arm:latest \
  --platform linux/arm64 \
  --file Dockerfile \
  .

The build result is:

[linux/arm64] TARGETPLATFORM='linux/arm64' TARGETOS='linux' TARGETARCH='arm64' TARGETVARIANT=''

Running this image:

docker rmi ${DOCKER_USER}/buildx-arm:latest
docker run --rm --platform linux/arm64 ${DOCKER_USER}/buildx-arm:latest

It will result:

(aarch64) TARGETPLATFORM='linux/arm64' TARGETOS='linux' TARGETARCH='arm64' TARGETVARIANT=''

If you change the buildx parameter --platform linux/arm64 to --platform linux/aarch64, the build result will be the same:

[linux/arm64] TARGETPLATFORM='linux/arm64' TARGETOS='linux' TARGETARCH='arm64' TARGETVARIANT=''

and the result of running this image will be the same too:

docker rmi ${DOCKER_USER}/buildx-arm:latest
docker run --rm --platform linux/aarch64 ${DOCKER_USER}/buildx-arm:latest

(aarch64) TARGETPLATFORM='linux/arm64' TARGETOS='linux' TARGETARCH='arm64' TARGETVARIANT=''

Even though the results are the same with aarch64 and arm64, GOARCH doesn't recognize the aarch64 value. That is the reason to use arm64 in that two lines of the Makefile.

sagikazarmark

I guess adding arm v7 support would also make sense (probably in a different PR).

I think something like goreleaser would be great for this project.

kaissi · 2021-01-11T21:36:24Z

@sagikazarmark At first, I made this PR with v7 support, but I realized that it could have a backward compatibility issue.

Try creating the Dockerfile I put here in this issue, and build it for armhf, running this command:

docker buildx build \
  --pull \
  --push \
  --tag ${DOCKER_USER}/buildx-arm:latest \
  --platform linux/armhf \
  --file Dockerfile \
  .

Now, try to run the following command:

docker rmi ${DOCKER_USER}/buildx-arm:latest
docker run --rm --platform linux/armhf ${DOCKER_USER}/buildx-arm:latest

It will result:

(armv7l) TARGETPLATFORM='linux/arm/v7' TARGETOS='linux' TARGETARCH='arm' TARGETVARIANT='v7'

As you can see, the docker builds armhf for v7 and not v6, as it is in the source code:

dockerize/Makefile

Line 27 in 9ce2e80

    
           mkdir -p dist/linux/armhf && GOOS=linux GOARCH=arm GOARM=6 go build -ldflags "$(LDFLAGS)" -o dist/linux/armhf/dockerize

Thus, how do we solve this by avoiding backward compatibility breaks? It would be another bug (it should be v7 instead of v6 on the 27th line)?

jpwhitemn · 2021-01-26T16:23:51Z

Hi @kaissi - could you provide any kind of guidance on this PR and availability of dockerize on arm64? I am the chairman of the EdgeX Foundry open source project. Our project discovered your tool and have already incorporated it into some of our work. As we run/support both Intel and ARM64 architectures, it would be incredibly helpful if the ARM64 version was made available soon.
Also tagging @sagikazarmark

kaissi · 2021-01-27T00:56:56Z

Hi @jpwhitemn. It's very simple to make these changes.

But, first, you could try using some of the other arm executables:

I'm saying that because in my Raspberry Pi 4, these two options work perfectly.

That said, let's go to this PR. While this PR is not merged you can do this by yourself. I'm assuming you are trying to execute the stable version - tag v0.6.1 (the latest right now).

Where you find ${GITHUB_USER}, you must put your Github user, like 'jpwhitemn', for instance.

Just follow these steps:

Fork this repo;
Clone your fork and create a branch based on the v0.6.1 tag:

git clone [email protected]:${GITHUB_USER}/dockerize.git
cd dockerize
git checkout -b 0.6.x v0.6.1

Add these two lines in the Makefile:

Add the following line in the block of the Makefile command 'dist: deps dist-clean':

mkdir -p dist/linux/arm64 && GOOS=linux GOARCH=arm64 go build -ldflags "$(LDFLAGS)" -o dist/linux/arm64/dockerize

Add the following line in the block of the Makefile command 'release: dist':

tar -cvzf dockerize-linux-arm64-$(TAG).tar.gz -C dist/linux/arm64 dockerize

In the command line, go to the project root folder, commit your change, push back to your fork, and generate a release:

git add --all
git commit -m "Added arm64 support"
git push origin 0.6.x
make release

All the tar files will be created in your project root folder - including the new dockerize-linux-arm64-v0.6.1.tar.gz tar file;
You can upload these generated tar files to the tag v0.6.1 of your fork, editing the tag, and uploading the tar files. The URL where you'll do this is https://github.com/${GITHUB_USER}/dockerize/releases/tag/v0.6.1, clicking in 'Edit tag';

After doing these steps you can use your Github URL in your projects.

jpwhitemn · 2021-01-27T19:55:56Z

thanks for this @kaissi . We were able to get things to work, but we were looking for formal acceptance of your PR and to know when this project might actually release again (last was March 2018)? Probably more of a question for @jwilder . We're trying to understand if this project is active or no longer supported.

kaissi · 2021-01-27T21:35:28Z

@jpwhitemn, related to acceptance of this PR only @jwilder can do it. And, if this project is active, see #120 (comment).

bourvill · 2021-03-24T10:57:15Z

Hello any update for this PR ? ping @jwilder

sanemat · 2021-09-02T07:08:53Z

Hello any update for this PR ? ping @jwilder

LoboMetalurgico · 2022-08-02T17:07:27Z

Hello any update for this PR ? ping @jwilder

odidev · 2023-04-28T11:13:25Z

@ jwilder, I have also tried with these steps mentioned in the issue

Hi @jpwhitemn. It's very simple to make these changes.

But, first, you could try using some of the other arm executables:

https://github.com/jwilder/dockerize/releases/download/v0.6.1/dockerize-linux-armel-v0.6.1.tar.gz

https://github.com/jwilder/dockerize/releases/download/v0.6.1/dockerize-linux-armhf-v0.6.1.tar.gz

I'm saying that because in my Raspberry Pi 4, these two options work perfectly.

That said, let's go to this PR. While this PR is not merged you can do this by yourself. I'm assuming you are trying to execute the stable version - tag v0.6.1 (the latest right now).

Where you find ${GITHUB_USER}, you must put your Github user, like 'jpwhitemn', for instance.

Just follow these steps:

Fork this repo;

Clone your fork and create a branch based on the v0.6.1 tag:
git clone [email protected]:${GITHUB_USER}/dockerize.git
cd dockerize
git checkout -b 0.6.x v0.6.1
Add these two lines in the Makefile:

Add the following line in the block of the Makefile command 'dist: deps dist-clean':

mkdir -p dist/linux/arm64 && GOOS=linux GOARCH=arm64 go build -ldflags "$(LDFLAGS)" -o dist/linux/arm64/dockerize

Add the following line in the block of the Makefile command 'release: dist':

tar -cvzf dockerize-linux-arm64-$(TAG).tar.gz -C dist/linux/arm64 dockerize

In the command line, go to the project root folder, commit your change, push back to your fork, and generate a release:
git add --all
git commit -m "Added arm64 support"
git push origin 0.6.x
make release
All the tar files will be created in your project root folder - including the new dockerize-linux-arm64-v0.6.1.tar.gz tar file;

You can upload these generated tar files to the tag v0.6.1 of your fork, editing the tag, and uploading the tar files. The URL where you'll do this is https://github.com/${GITHUB_USER}/dockerize/releases/tag/v0.6.1, clicking in 'Edit tag';

After doing these steps you can use your Github URL in your projects.

In the dockerize git repo the binaries are released for armel and armhf. By running the above steps, the arm64 binaries got built successfully. So, could you please release the binaries for arm64 architecture. Please let me know if you need any help in releasing the arm64 binaries.

Could you please merge this PR, it would be really helpful.

Thanks in advance!

Fixed jwilder#143 - aarch64 support is not correct in the Makefile

bed4278

This was referenced Oct 30, 2020

ARM / arm64 support? #154

Closed

aarch64 release missing? #143

Closed

Fix mkdir path for aarch64 #131

Merged

kaissi changed the title ~~Fixed jwilder/dockerize#143 - aarch64 support is not correct in the Makefile~~ aarch64 support is not correct in the Makefile Nov 13, 2020

sagikazarmark approved these changes Jan 1, 2021

View reviewed changes

nolili mentioned this pull request May 17, 2021

Added arm64 support nolili/dockerize#1

Merged

bradenmacdonald mentioned this pull request Feb 26, 2022

arm64: dockerize: Exec format error on mysql init overhangio/tutor#591

Closed

Merge branch 'master' into master

22bc6fe

jwilder merged commit 94c73b1 into jwilder:master May 1, 2023

odidev mentioned this pull request May 2, 2023

request a new release for arm64 #185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

aarch64 support is not correct in the Makefile #155

aarch64 support is not correct in the Makefile #155

kaissi commented Oct 30, 2020 •

edited

Loading

sagikazarmark left a comment

kaissi commented Jan 11, 2021

jpwhitemn commented Jan 26, 2021 •

edited

Loading

kaissi commented Jan 27, 2021

jpwhitemn commented Jan 27, 2021

kaissi commented Jan 27, 2021 •

edited

Loading

bourvill commented Mar 24, 2021

sanemat commented Sep 2, 2021

LoboMetalurgico commented Aug 2, 2022

odidev commented Apr 28, 2023

aarch64 support is not correct in the Makefile #155

aarch64 support is not correct in the Makefile #155

Conversation

kaissi commented Oct 30, 2020 • edited Loading

sagikazarmark left a comment

Choose a reason for hiding this comment

kaissi commented Jan 11, 2021

jpwhitemn commented Jan 26, 2021 • edited Loading

kaissi commented Jan 27, 2021

jpwhitemn commented Jan 27, 2021

kaissi commented Jan 27, 2021 • edited Loading

bourvill commented Mar 24, 2021

sanemat commented Sep 2, 2021

LoboMetalurgico commented Aug 2, 2022

odidev commented Apr 28, 2023

kaissi commented Oct 30, 2020 •

edited

Loading

jpwhitemn commented Jan 26, 2021 •

edited

Loading

kaissi commented Jan 27, 2021 •

edited

Loading