Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 bit floating point #27

Closed
wants to merge 2 commits into from
Closed

32 bit floating point #27

wants to merge 2 commits into from

Conversation

ArturSkowronski
Copy link
Contributor

https://www.youtube.com/watch?v=ji3SfClm8TU - In this video there is an error. It was hard to grasp for me and took a moment before I've seen description of video informed about it.

https://www.youtube.com/watch?v=ji3SfClm8TU - In this video there is an error. It was hard to grasp for me and took a moment before I've seen description of video informed about it.
@@ -323,7 +323,7 @@ Write code on a whiteboard, not a computer. Test with some sample inputs. Then t
- [ ] [Machine Code Instructions (video)](https://www.youtube.com/watch?v=Mv2XQgpbTNE)

- [ ] **How floating point numbers are stored:**
- [ ] simple 8-bit: [Fractions in binary? (video)](https://math.stackexchange.com/questions/301435/fractions-in-binary)
- [ ] simple 8-bit: [Fractions in binary? (video)] (There is an error in calculation in video - see description) (https://math.stackexchange.com/questions/301435/fractions-in-binary)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Artur, please move the annotation inside the [] portion. This is a markdown-style link and would break it:

format:
[link text](link url)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually hold until I get this next big commit in. One moment.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK merge and go for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for comments - I changed format to suits markdown better

Putting comment in brackets
@ArturSkowronski
Copy link
Contributor Author

I put comment in video brackets

@jwasham
Copy link
Owner

jwasham commented Oct 9, 2016

Sorry, that conflicts now. I had removed that first link, and you added the annotation to it. :)

@ArturSkowronski
Copy link
Contributor Author

You know what - I will drop it and create new pull request. It will be easier that way :)

esaucedof pushed a commit to esaucedof/coding-interview-university that referenced this pull request May 23, 2017
jwasham pushed a commit that referenced this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants