-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gsm): add error_category
and error_sub_category
columns to gsm table
#6648
Open
Chethan-rao
wants to merge
6
commits into
main
Choose a base branch
from
add-error-category-to-gsm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
C-refactor
Category: Refactor
labels
Nov 24, 2024
Changed Files
|
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Nov 24, 2024
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Nov 24, 2024
crates/api_models/src/gsm.rs
Outdated
#[serde(rename_all = "snake_case")] | ||
#[strum(serialize_all = "snake_case")] | ||
pub enum ErrorCategory { | ||
IssuerDecline, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have ConnectorErrorType
which is used for different purpose in auto retries flow, and has the following values
UserError, BusinessError, TechnicalError, UnknownError
Should we follow the same here? @Chethan-rao
cc: @jarnura
…itch into add-error-category-to-gsm
Chethan-rao
force-pushed
the
add-error-category-to-gsm
branch
from
November 25, 2024 11:33
f6ca1dc
to
86cc950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds
error_category
anderror_sub_category
columns to gsm table which is an enum in application. These could be used to take multiple decisions in future but currently these are required for elimination routing in which these categories will serve as bucket name.Additionally it fixes the
last_modified
column not being updated in gsm table during/update
Additional Changes
Motivation and Context
How did you test it?
Added 2 new columns to GSM tables. (error_category, error_sub_category)
Checklist
cargo +nightly fmt --all
cargo clippy