feat(payment_link): add multiple custom css support in business level #5137

sahkal · 2024-06-26T15:22:02Z

Type of Change

Enhancement

Description

Currently we support one theme config for payment link that can be set in business profile level, with this PR we will allow multiple payment link theme configuration in business profile.

Additional Changes

This PR modifies the API contract

"payment_link_config": {
        "theme": "#8A0808",
        "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
        "seller_name": "sahkal",
        "display_sdk_only": false,
        "business_specific_configs": {
            "key1": {
                "theme": "#3B845E",
                "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
                "seller_name": "sahkal",
                "display_sdk_only": true
            },
            "key2": {
                "theme": "#B202FF",
                "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
                "seller_name": "sahkal",
                "enabled_saved_payment_method":true
                // "display_sdk_only": true
            }
        }
    }
}

we are adding a new optional param that is business_specific_configs for multi theme configuration

How did you test it?

Create Merchant account

curl --location 'http:https://localhost:8080/accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data-raw '{
  "merchant_id": "merchant_1719479157",
  "locker_id": "m0010",
  "merchant_name": "NewAge Retailer",
  "merchant_details": {
    "primary_contact_person": "John Test",
    "primary_email": "[email protected]",
    "primary_phone": "sunt laborum",
    "secondary_contact_person": "John Test2",
    "secondary_email": "[email protected]",
    "secondary_phone": "cillum do dolor id",
    "website": "www.example.com",
    "about_business": "Online Retail with a wide selection of organic products for North America",
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US"
    }
  },
  "webhook_details": {
    "webhook_version": "1.0.1",
    "webhook_username": "ekart_retail",
    "webhook_password": "password_ekart@123",
    "webhook_url":"https://eny91mlyw8bh.x.pipedream.net",
    "payment_created_enabled": true,
    "payment_succeeded_enabled": true,
    "payment_failed_enabled": true
  },
  "sub_merchants_enabled": false,
  "metadata": {
    "city": "NY",
    "unit": "245"
  },
  "primary_business_details": [
    {
      "country": "US",
      "business": "default"
    }
  ]
}'

Create Payment Connector

curl --location 'http:https://localhost:8080/account/merchant_1719470020/connectors' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '
{
    "connector_type": "fiz_operations",
    "connector_name": "stripe",
    "connector_account_details": {
        "auth_type": "HeaderKey",
        "api_key":  {stripe-api-key}
    },
    "test_mode": true,
    "disabled": false,
    "connector_webhook_details": {
        "merchant_secret": {stripe-merchant-secret}
    },
    
    "payment_methods_enabled": [
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "AmericanExpress",
                        "DinersClub",
                        "Discover",
                        "JCB",
                        "Mastercard",
                        "Visa"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "accepted_currencies": {
                        "type": "enable_only",
                        "list": [
                            "CZK",
                            "RON",
                            "TRY",
                            "USD",
                            "GBP",
                            "CAD",
                            "AUD",
                            "ARS",
                            "CHF",
                            "CNY",
                            "DKK",
                            "GHS",
                            "JPY",
                            "PLN",
                            "NGN",
                            "NOK",
                            "KES",
                            "SEK",
                            "NZD",
                            "ZAR",
                            "SGD",
                            "INR"
                        ]
                    }
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "AmericanExpress",
                        "DinersClub",
                        "Discover",
                        "JCB",
                        "Mastercard",
                        "Visa"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "accepted_currencies": {
                        "type": "enable_only",
                        "list": [
                            "CZK",
                            "RON",
                            "TRY",
                            "USD",
                            "GBP",
                            "CAD",
                            "AUD",
                            "ARS",
                            "CHF",
                            "CNY",
                            "DKK",
                            "GHS",
                            "JPY",
                            "PLN",
                            "NGN",
                            "NOK",
                            "KES",
                            "SEK",
                            "NZD",
                            "ZAR",
                            "SGD",
                            "INR"
                        ]
                    }
                },
                {
                    "payment_method_type": "credit",
                    "card_networks": [
                        "Mastercard",
                        "Visa"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "accepted_currencies": {
                        "type": "enable_only",
                        "list": [
                            "EUR"
                        ]
                    }
                },
                {
                    "payment_method_type": "debit",
                    "card_networks": [
                        "Mastercard",
                        "Visa"
                    ],
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "accepted_currencies": {
                        "type": "enable_only",
                        "list": [
                            "EUR"
                        ]
                    }
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "affirm"
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "afterpay_clearpay"
                }
            ]
        },
        {
            "payment_method": "bank_redirect",
            "payment_method_types": [
                {
                    "payment_method_type": "sofort",
                    "payment_experience": "redirect_to_url",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": false
                },
                {
                    "payment_method_type": "bancontact_card",
                    "payment_experience": "redirect_to_url",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": false
                },
                {
                    "payment_method_type": "ideal",
                    "payment_experience": "redirect_to_url",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": false
                },
                {
                    "payment_method_type": "blik",
                    "payment_experience": "redirect_to_url",
                    "card_networks": null,
                    "accepted_currencies": null,
                    "accepted_countries": null,
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "redirect_to_url",
                    "payment_method_type": "klarna"
                }
            ]
        },
        {
            "payment_method": "pay_later",
            "payment_method_types": [
                {
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true,
                    "payment_experience": "invoke_sdk_client",
                    "payment_method_type": "klarna"
                }
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "credit",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "card",
            "payment_method_types": [
                {
                    "payment_method_type": "debit",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "apple_pay",
                    "payment_experience": "invoke_sdk_client",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                }
            ]
        },
        {
            "payment_method": "wallet",
            "payment_method_types": [
                {
                    "payment_method_type": "google_pay",
                    "payment_experience": "invoke_sdk_client",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "recurring_enabled": true,
                    "installment_payment_enabled": true
                },
                {
                    "payment_method_type": "paypal",
                    "payment_experience": "redirect_to_url",
                    "minimum_amount": 1,
                    "maximum_amount": 68607706,
                    "installment_payment_enabled": true,
                    "recurring_enabled": true
                }
            ]
        }
    ],
    "metadata": {
        "google_pay": {
            "allowed_payment_methods": [
                {
                    "type": "CARD",
                    "parameters": {
                        "allowed_auth_methods": [
                            "PAN_ONLY",
                            "CRYPTOGRAM_3DS"
                        ],
                        "allowed_card_networks": [
                            "AMEX",
                            "DISCOVER",
                            "INTERAC",
                            "JCB",
                            "MASTERCARD",
                            "VISA"
                        ]
                    },
                    "tokenization_specification": {
                        "type": "PAYMENT_GATEWAY",
                        "parameters": {
                            "gateway": "example",
                            "gateway_merchant_id": {publishable_key}
                        }
                    }
                }
            ],
            "merchant_info": {
                "merchant_name": "Narayan Bhat"
            }
        },
        "apple_pay": {
            "session_token_data": {
                "initiative": "web",
                "certificate": {certificate},
                "display_name": "applepay",
                "certificate_keys": {certificate_keys},
                "initiative_context": "hyperswitch-sdk-test.netlify.app",
                "merchant_identifier": "merchant.com.stripe.sang"
            },
            "payment_request_data": {
                "label": "applepay pvt.ltd",
                "supported_networks": [
                    "visa",
                    "masterCard",
                    "amex",
                    "discover"
                ],
                "merchant_capabilities": [
                    "supports3DS"
                ]
            }
        }
    }
}
'

Create Api-key

curl --location 'http:https://localhost:8080/api_keys/merchant_1719479670' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
  "name": "API Key 1",
  "description": null,
  "expiration": "2025-09-23T01:02:03.000Z"
}'

Now,

Updating the default business profile with payment link config with business_specific_configs

curl --location 'http:https://localhost:8080/account/merchant_1719479670/business_profile/pro_yl0tPMSCxxJlndl0aMHz' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
"payment_link_config": {
        "theme": "#8A0808",
        "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
        "seller_name": "sahkal",
        "display_sdk_only": false,
        "business_specific_configs": {
            "key1": {
                "theme": "#3B845E",
                "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
                "seller_name": "sahkal",
                "display_sdk_only": true
            },
            "key2": {
                "theme": "#B202FF",
                "logo": "https://i.pinimg.com/736x/4d/83/5c/4d835ca8aafbbb15f84d07d926fda473.jpg",
                "seller_name": "sahkal",
                "enabled_saved_payment_method":true
                
            }
        }
    }
}'

Do Payments Create

Case 1: incase, business_specific_configs is present and key is not send in payment create request, config will be picked up from the default config.

curl --location 'http:https://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_DZb1asJFT5ywRneS0niZUSrkXAiwGopwoWDKETATbIJqvPm2hj58q1Yrpbhqdb6D' \
--data-raw '
{
    "amount": 6540,
    "currency": "USD",
     "payment_link": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "stripesavecard_1234",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "on_session",
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "127.0.0.1",
            "user_agent": "amet irure esse"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "routing": {
        "type": "single",
        "data": "stripe"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "session_expiry": 2423545
}'

Case 2:incase, business_specific_configs is present and key is send in the request, then it should pick up config from the config mapped to the key in business profile.

curl --location 'http:https://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_DZb1asJFT5ywRneS0niZUSrkXAiwGopwoWDKETATbIJqvPm2hj58q1Yrpbhqdb6D' \
--data-raw '
{
    "amount": 6540,
    "currency": "USD",
     "payment_link": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "stripesavecard_1234",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "on_session",
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "127.0.0.1",
            "user_agent": "amet irure esse"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "routing": {
        "type": "single",
        "data": "stripe"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "session_expiry": 2423545,
    "payment_link_config_id":"key1"
}

Case 3 :incase, business_specific_configs is present and invalid key is send in the request, then it should pick up default config from business profile.

curl --location 'http:https://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_DZb1asJFT5ywRneS0niZUSrkXAiwGopwoWDKETATbIJqvPm2hj58q1Yrpbhqdb6D' \
--data-raw '
{
    "amount": 6540,
    "currency": "USD",
     "payment_link": true,
    "capture_method": "automatic",
    "capture_on": "2022-09-10T10:11:12Z",
    "amount_to_capture": 6540,
    "customer_id": "stripesavecard_1234",
    "email": "[email protected]",
    "name": "John Doe",
    "phone": "999999999",
    "phone_country_code": "+65",
    "description": "Its my first payment request",
    "authentication_type": "no_three_ds",
    "return_url": "https://google.com",
    "setup_future_usage": "on_session",
    "customer_acceptance": {
        "acceptance_type": "offline",
        "accepted_at": "1963-05-03T04:07:52.723Z",
        "online": {
            "ip_address": "127.0.0.1",
            "user_agent": "amet irure esse"
        }
    },
    "billing": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "shipping": {
        "address": {
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "city": "San Fransico",
            "state": "California",
            "zip": "94122",
            "country": "US",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        }
    },
    "routing": {
        "type": "single",
        "data": "stripe"
    },
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "metadata": {
        "udf1": "value1",
        "new_customer": "true",
        "login_date": "2019-09-10T10:11:12Z"
    },
    "session_expiry": 2423545,
    "payment_link_config_id":"key234"
}

Note: Next test cases, can be tested based on creating new business profile, and doing feature and edge case testing.

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

…siness-level-for-payment-link' of https://github.com/juspay/hyperswitch into 5582-payment-link-add-multiple-custom-css-support-in-business-level-for-payment-link

…ig contract

…siness-level-for-payment-link' of https://github.com/juspay/hyperswitch into 5582-payment-link-add-multiple-custom-css-support-in-business-level-for-payment-link

…pport-in-business-level-for-payment-link

jarnura · 2024-06-28T07:39:06Z

crates/router/src/core/payment_link.rs

- .to_currency_base_unit(payment_intent.amount.get_amount_as_i64())
- .change_context(errors::ApiErrorResponse::CurrencyConversionFailed)?;
+
+ let required_conversion_type = StringMajorUnitForConnector;


We should have a different type for this like StringMajorUnit

i cant use pub struct StringMajorUnit since we are already using it for conversion type pub struct StringMajorUnit(String)

done, added StringMajorUnitForCore type to impl on!

Narayanbhat166 · 2024-07-01T08:57:56Z

crates/api_models/src/payments.rs

@@ -468,6 +468,9 @@ pub struct PaymentsRequest {
 #[schema(value_type = Option<PaymentCreatePaymentLinkConfig>)]
 pub payment_link_config: Option<PaymentCreatePaymentLinkConfig>,

+ /// custom payment link config id set at business profile send only if business_specific_configs is configured
+ pub payment_link_config_id: Option<String>,


can this be sent in Confirm and update as well? If not can you hide it in the api ref for those two requests?

…#5137) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>

…ror-handling-in-cypress * 'main' of github.com:juspay/hyperswitch: fix(auth_methods): Add checks for duplicate `auth_method` in create API (#5161) chore(version): 2024.07.02.0 fix(router): rename the browser name header to `x-browser-name` (#5162) fix(router): mark retry payment as failure if `connector_tokenization` fails (#5114) fix(connector): [Paypal] dispute webhook deserialization failure (#5111) feat(analytics): Add v2 payment analytics (payment-intents analytics) (#5150) feat(globalsearch): Implement tag-based filters in global search (#5151) refactor(connector): Add amount conversion framework to iatapay along with amount conversion code to connector template (#4866) feat(payment_link): add multiple custom css support in business level (#5137) feat(connector): [Bambora Apac] Template for integration (#5062) feat(tls): add support for https in actix web (#5089) chore(ci): fix ci tests failing by removing them (#5167) chore(version): 2024.07.01.0 chore(postman): update Postman collection files ci(postman): log request id for user tests (#5159) chore(euclid_wasm): make field domain optional wasm (#5154)

sahkal added 2 commits June 26, 2024 20:21

refactor(router): added multi css support for payment link

0ad46c6

refactor(router): added payment_link_config_macro! to get values

01132c3

sahkal requested review from a team as code owners June 26, 2024 15:22

sahkal changed the title ~~feat(paymentlink): add multiple custom css support in business level for payment link~~ feat(paymentlink): add multiple custom css support in business level Jun 26, 2024

sahkal requested review from Narayanbhat166 and jarnura June 26, 2024 15:22

sahkal self-assigned this Jun 26, 2024

sahkal added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jun 26, 2024

sahkal added this to the June 2024 Release milestone Jun 26, 2024

docs(openapi): re-generate OpenAPI specification

ecba474

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jun 26, 2024

sahkal added 2 commits June 27, 2024 13:13

refactor(payment_link): added amount framework to payment link

ad28bb7

Merge branch '5582-payment-link-add-multiple-custom-css-support-in-bu…

debf8d4

…siness-level-for-payment-link' of https://github.com/juspay/hyperswitch into 5582-payment-link-add-multiple-custom-css-support-in-business-level-for-payment-link

sahkal requested a review from a team as a code owner June 27, 2024 07:44

refactor(payment_link): added backward compatible additional css conf…

70169d5

…ig contract

sahkal changed the title ~~feat(paymentlink): add multiple custom css support in business level~~ feat(payment_link): add multiple custom css support in business level Jun 27, 2024

hyperswitch-bot bot and others added 6 commits June 27, 2024 08:20

docs(openapi): re-generate OpenAPI specification

66fbd3c

refactor(payment_link): fixed spell check and open-api failures

18699b9

Merge branch '5582-payment-link-add-multiple-custom-css-support-in-bu…

4107600

…siness-level-for-payment-link' of https://github.com/juspay/hyperswitch into 5582-payment-link-add-multiple-custom-css-support-in-business-level-for-payment-link

refactor(payment_link): fixed ci check failures

efc11fa

Merge branch 'main' into 5582-payment-link-add-multiple-custom-css-su…

e11f987

…pport-in-business-level-for-payment-link

Merge branch 'main' into 5582-payment-link-add-multiple-custom-css-su…

a818bed

…pport-in-business-level-for-payment-link

jarnura requested changes Jun 28, 2024

View reviewed changes

refactor(payment_link): addressed pr comments

7bd12da

sahkal requested a review from jarnura June 28, 2024 08:54

jarnura approved these changes Jun 28, 2024

View reviewed changes

Narayanbhat166 reviewed Jul 1, 2024

View reviewed changes

Narayanbhat166 approved these changes Jul 1, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Jul 1, 2024

github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024

feat(payment_link): add multiple custom css support in business level (…

a7e9d28

…#5137) Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2024

bernard-eugine modified the milestones: June 2024 Release, July 2024 Release Jul 1, 2024

Gnanasundari24 added this pull request to the merge queue Jul 1, 2024

Merged via the queue into main with commit ecc6c00 Jul 1, 2024
11 checks passed

Gnanasundari24 deleted the 5582-payment-link-add-multiple-custom-css-support-in-business-level-for-payment-link branch July 1, 2024 11:16

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jul 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(payment_link): add multiple custom css support in business level #5137

feat(payment_link): add multiple custom css support in business level #5137

sahkal commented Jun 26, 2024 •

edited

Loading

jarnura Jun 28, 2024

sahkal Jun 28, 2024

sahkal Jun 28, 2024

Narayanbhat166 Jul 1, 2024

feat(payment_link): add multiple custom css support in business level #5137

feat(payment_link): add multiple custom css support in business level #5137

Conversation

sahkal commented Jun 26, 2024 • edited Loading

Type of Change

Description

Additional Changes

How did you test it?

Checklist

jarnura Jun 28, 2024

Choose a reason for hiding this comment

sahkal Jun 28, 2024

Choose a reason for hiding this comment

sahkal Jun 28, 2024

Choose a reason for hiding this comment

Narayanbhat166 Jul 1, 2024

Choose a reason for hiding this comment

sahkal commented Jun 26, 2024 •

edited

Loading