-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): addition of shipping address details in payment intent #5112
Merged
Gnanasundari24
merged 49 commits into
main
from
feat/shipping_address_details_in_payment_intent
Jul 8, 2024
Merged
feat(core): addition of shipping address details in payment intent #5112
Gnanasundari24
merged 49 commits into
main
from
feat/shipping_address_details_in_payment_intent
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/juspay/hyperswitch into feat/business_address_in_payment_intent
…hub.com/juspay/hyperswitch into feat/business_address_in_payment_intent
prajjwalkumar17
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
labels
Jun 25, 2024
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Jun 25, 2024
…ping_address_details_in_payment_intent
lsampras
reviewed
Jul 1, 2024
crates/hyperswitch_domain_models/src/payments/payment_intent.rs
Outdated
Show resolved
Hide resolved
…ping_address_details_in_payment_intent
…ps:https://github.com/juspay/hyperswitch into feat/shipping_address_details_in_payment_intent
lsampras
previously approved these changes
Jul 5, 2024
…s:https://github.com/juspay/hyperswitch into feat/shipping_address_details_in_payment_intent
…ps:https://github.com/juspay/hyperswitch into feat/shipping_address_details_in_payment_intent
create_encrypted_data( | ||
key_store, | ||
payment_data.address.get_payment_billing().cloned(), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create another function which will take the data and encrypt it, and rename this function to indicate that this encrypts optional data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure this will be taken up in the very next PR.
Narayanbhat166
approved these changes
Jul 8, 2024
lsampras
approved these changes
Jul 8, 2024
swangi-kumari
approved these changes
Jul 8, 2024
Gnanasundari24
deleted the
feat/shipping_address_details_in_payment_intent
branch
July 8, 2024 10:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds a new column in Payment Intent for storing shipping address details(Encrypted)
Additional Changes
The Db Migration:
Motivation and Context
How did you test it?
The testing scenarios and flow is as follow:
1. Payment Create
2. Payment Update
3. Payment Confirm
Checklist
cargo +nightly fmt --all
cargo clippy