feat: add mtls for keymanager api requests #5048
Open
+106
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
dracarys18
changed the title
…h into add_mtls_keymanager
…nto add_mtls_keymanager
Comment on lines
+26
to
+34
| #[cfg(feature = "keymanager_mtls")] | ||
| { | ||
| let ca = state.conf.key_manager.ca.clone(); | ||
| let cert = state.conf.key_manager.cert.clone(); | ||
|
|
||
| let identity = reqwest::Identity::from_pem(cert.peek().as_ref()) | ||
| .change_context(errors::ApiClientError::ClientConstructionFailed)?; | ||
| let ca_cert = reqwest::Certificate::from_pem(ca.peek().as_ref()) | ||
| .change_context(errors::ApiClientError::ClientConstructionFailed)?; |
There was a problem hiding this comment.
you can use
if cfg!(feature = "keymanager_mtls") you would not need #[allow(unused_mut)] in that case
There was a problem hiding this comment.
We cannot do this since ca and cert have compile time feature constraints
…h into add_mtls_keymanager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add mTLS while calling keymanager service
Additional Changes
Motivation and Context
This PR adds a new
reqwest::Clientwith Certificates and CA to contact with the key managerHow did you test it?
Checklist
cargo +nightly fmt --allcargo clippy