ci(cypress): Add Payment Method Id mandate flows #5035
Conversation
likhinbopanna
added
A-CI-CD
cypress-tests/cypress/e2e/PaymentTest/00018-MandatesUsingPMID.cy.js
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/PaymentTest/00018-MandatesUsingPMID.cy.js
Outdated
Show resolved
Hide resolved
| () => { | ||
| it("Create No 3DS Payment Intent", () => { |
There was a problem hiding this comment.
"future proofing" needs to be done.
Again, TL;DR: Add it to the beginning of every context()
cypress-tests/cypress/e2e/PaymentTest/00018-MandatesUsingPMID.cy.js
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/PaymentTest/00018-MandatesUsingPMID.cy.js
Outdated
Show resolved
Hide resolved
| mandate_data: null, | ||
| customer_acceptance: { | ||
| acceptance_type: "offline", | ||
| accepted_at: "1963-05-03T04:07:52.723Z", | ||
| online: { | ||
| ip_address: "125.0.0.1", | ||
| user_agent: "amet irure esse", | ||
| }, |
There was a problem hiding this comment.
We can move these to a const and call it like we do for singleUseMandateData and multiUseMandateData. Possibly put that in commons.js and import?
This needs to be done everywhere to reduce duplicate code.
There was a problem hiding this comment.
we can take this up later
There was a problem hiding this comment.
Since these changes are introduced in this PR and still need more review, I thought of getting this right in this PR itself. If other reviewers are okay with this, I've no issues.
There was a problem hiding this comment.
This not introduced in this PR , this is replicated from mandate_id test cases , so we can have other PR for all the Tests
There was a problem hiding this comment.
Cool, we should take this up in the coming PR and not leave it as it is.
| mandate_data: null, | ||
| customer_acceptance: { | ||
| acceptance_type: "offline", | ||
| accepted_at: "1963-05-03T04:07:52.723Z", | ||
| online: { | ||
| ip_address: "125.0.0.1", | ||
| user_agent: "amet irure esse", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
here as well., below, everywhere.
pixincreate
removed
the
S-waiting-on-review
Type of Change
Description
Added
payment_method_idmandate flows to Cypress automation, previously onlymandate_idflows were included.Currently implemented connectors - Cybersource , Stripe , Adyen and Bankofamerica
Additional Changes
Motivation and Context
Currently we had only mandate_id flows so added pmid mandate flows
How did you test it?
CYPRESS:
Checklist
cargo +nightly fmt --allcargo clippy