feat(connector): [DATATRANS] Implement card payments #5028

awasthi21 · 2024-06-18T12:14:36Z

Type of Change

Description

Implemented Card Payments for Datatrans

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

#5027

How did you test it?

Attached Postman Collection postman/collection-json/datatrans.postman_collection.json

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

deepanshu-iiitu · 2024-06-20T07:25:56Z

Rename PR to: feat(connector): [DATATRANS] Implement card payments
Add the issue link #5027 in the Motivation and Context section of this PR.

Also add description in the issue #5027

crates/router/src/connector/datatrans.rs

crates/router/src/connector/datatrans/transformers.rs

deepanshu-iiitu · 2024-06-21T10:33:05Z

crates/router/src/connector/datatrans.rs

- reason: response.reason,
+ code: error_code,
+ message: error_message.clone(),
+ reason: Some(error_message),


Remove the some here as mentioned in the previous comment.

reason is Option here
and
error_message is String

deepanshu-iiitu · 2024-06-21T10:36:23Z

crates/router/src/connector/datatrans.rs

 .unwrap_or(consts::NO_ERROR_CODE.to_string());
 let error_message = response
 .error
 .as_ref()
- .and_then(|e| e.message.clone())
+ .map(|e| e.message.clone())


Move this unwrap_or to the message field below. And remove the some used for reason

deepanshu-iiitu · 2024-06-21T10:37:36Z

crates/router/src/connector/datatrans/transformers.rs

 },
 };

+#[derive(Default, Debug, Clone, Serialize, Deserialize)]
+pub struct DatatransErrorResponse {
+ pub error: Option<DatatransError>,


Why is this made option?

Removed That

deepanshu-iiitu · 2024-06-21T10:39:14Z

crates/router/src/connector/datatrans/transformers.rs

+#[derive(Serialize, Deserialize, Clone, Debug)]
+#[serde(rename_all = "camelCase")]
+pub struct PlainCardDetails {
+ #[serde(rename = "type", default = "default_res_type")]


This hard coding should've been done in the try_from.

deepanshu-iiitu · 2024-06-21T10:39:42Z

crates/router/src/connector/datatrans/transformers.rs

 pub enum CardType {
- #[serde(rename = "card")]
- PLAIN(PlainCardDetails),
+ PlainCardDetails,
 ALIAS,
 NetworkTOKEN,
 DeviceTOKEN,
 }


Remove this unused enum

crates/router/src/connector/datatrans/transformers.rs

deepanshu-iiitu · 2024-06-21T10:48:29Z

crates/router/src/connector/datatrans/transformers.rs

- _ => common_enums::AttemptStatus::Failure,
- },
+ DataTransCaptureResponse::Error(error) => {
+ if error.message == *"already settled" {


Suggested change

if error.message == *"already settled" {

if error.message == "already settled".to_string() {

warning: this creates an owned instance just for comparison
--> crates/router/src/connector/datatrans/transformers.rs:517:37
|
517 | if error.message == "already settled".to_string() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: *"already settled"

Was getting this warning while running the cargo clippy --all-features --all-targets

deepanshu-iiitu · 2024-06-21T10:48:46Z

crates/router/src/connector/datatrans/transformers.rs

- {
- "transaction already canceled" => common_enums::AttemptStatus::Voided,
- _ => common_enums::AttemptStatus::Failure,
+ if error.message == *"transaction already canceled" {


Suggested change

if error.message == *"transaction already canceled" {

if error.message == "transaction already canceled".to_string() {

Please maintain constants for such strings

deepanshu-iiitu · 2024-06-21T10:49:49Z

We also need to implement the new amount conversion framework.
Please reference the noon changes from this PR and implement the same in Datatrans
#4843

crates/router/src/connector/datatrans.rs

SamraatBansal · 2024-06-26T10:58:57Z

crates/router/src/connector/datatrans.rs

+ Ok(format!(
+ "{}v1/transactions/{}",
+ self.base_url(connectors),
+ connector_payment_id
+ ))


crates/router/src/connector/datatrans.rs

crates/router/src/connector/datatrans/transformers.rs

SamraatBansal · 2024-06-30T09:49:27Z

crates/router/src/connector/datatrans/transformers.rs

- {
- "transaction already canceled" => common_enums::AttemptStatus::Voided,
- _ => common_enums::AttemptStatus::Failure,
+ if error.message == *"transaction already canceled" {


Please maintain constants for such strings

crates/router/src/connector/datatrans/transformers.rs

crates/router/src/connector/datatrans.rs

pixincreate · 2024-07-14T15:17:43Z

cypress-tests/cypress/e2e/PaymentUtils/Utils.js

@@ -23,6 +24,7 @@ const connectorDetails = {
 paypal: paypalConnectorDetails,
 stripe: stripeConnectorDetails,
 trustpay: trustpayConnectorDetails,
+ datatrans:datatransConnectorDetails


Was this connector tested?

Since this is a new connector, tests against other connectors needs to be run as well just to see if it affects other connectors although it shouldn't be. Was that done?

Looks like lints were not fixed either

And yes, creds are not updated

* 'main' of github.com:juspay/hyperswitch: (25 commits) fix(logs): ignore request headers while logging (#5273) feat(webhooks): add support for custom outgoing webhook http headers (#5275) fix(payment_methods): set `requires_cvv` to false when either `connector_mandate_details` or `network_transaction_id` is present during MITs (#5331) chore: create justfile for running commands for v1 and v2 migrations (#5325) fix(routing): do not update `perform_session_flow_routing` output if the `SessionRoutingChoice` is none (#5336) fix(database): modified_at updated for every state change for Payment Attempts (#5312) feat(mca): Added recipient connector call for open banking connectors (#3758) chore(version): 2024.07.16.0 refactor(connector): [Mifinity] add a field language_preference in payment request for mifinity payment method data (#5326) fix(router): store `customer_acceptance` in payment_attempt, use it in confirm flow for delayed authorizations like external 3ds flow (#5308) feat(proxy): add support to pass proxy bypass urls from configs (#5322) Docs: Updating Error codes in API-ref (#5296) feat(core): [Payouts] Add retrieve flow for payouts (#4936) fix(connector): [AUTHORIZEDOTNET] Populate error reason for failure transactions (#5319) chore(version): 2024.07.15.0 feat(logging): Emit a setup error when a restricted keys are used for logging default keys (#5185) feat(payment_methods): add support to migrate existing customer PMs from processor to hyperswitch (#5306) feat(connector): [DATATRANS] Implement card payments (#5028) chore: making of function create_encrypted_data (#5251) fix(payments): populate merchant order ref id in list (#5310) ...

awasthi21 added the A-connector-integration Area: Connector integration label Jun 18, 2024

awasthi21 self-assigned this Jun 18, 2024

awasthi21 requested review from a team as code owners June 18, 2024 12:14

awasthi21 linked an issue Jun 18, 2024 that may be closed by this pull request

feat(connector): [DATATRANS] add Connector Payment Flows Code #5027

Closed

hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jun 18, 2024

awasthi21 force-pushed the 5027-datatrans-connector-integration branch from d2edc7e to 95ebb7b Compare June 18, 2024 12:19

awasthi21 requested review from SamraatBansal, AkshayaFoiger and deepanshu-iiitu June 18, 2024 12:26

deepanshu-iiitu requested changes Jun 20, 2024

View reviewed changes

awasthi21 changed the title ~~feat(connector): added payment flows code~~ feat(connector): [DATATRANS] Implement card payments Jun 21, 2024

awasthi21 requested a review from a team as a code owner June 21, 2024 10:14

deepanshu-iiitu requested changes Jun 21, 2024

View reviewed changes

awasthi21 force-pushed the 5027-datatrans-connector-integration branch 2 times, most recently from 54fed06 to 30f1c61 Compare June 22, 2024 13:58

deepanshu-iiitu previously approved these changes Jun 24, 2024

View reviewed changes

awasthi21 dismissed deepanshu-iiitu’s stale review via 5cee8bd June 24, 2024 14:06

awasthi21 force-pushed the 5027-datatrans-connector-integration branch from 5cee8bd to a622ab6 Compare June 25, 2024 03:05

SamraatBansal requested changes Jun 30, 2024

View reviewed changes

awasthi21 force-pushed the 5027-datatrans-connector-integration branch from 28afc6f to abd9739 Compare July 5, 2024 10:19

AkshayaFoiger reviewed Jul 8, 2024

View reviewed changes

crates/router/src/connector/datatrans/transformers.rs Outdated Show resolved Hide resolved

crates/router/src/connector/datatrans.rs Show resolved Hide resolved

awasthi21 force-pushed the 5027-datatrans-connector-integration branch from 5bcafa8 to dd2b801 Compare July 8, 2024 10:12

AkshayaFoiger previously approved these changes Jul 9, 2024

View reviewed changes

SamraatBansal reviewed Jul 9, 2024

View reviewed changes

crates/router/src/connector/datatrans.rs Show resolved Hide resolved

SamraatBansal previously approved these changes Jul 11, 2024

View reviewed changes

SanchithHegde previously approved these changes Jul 11, 2024

View reviewed changes

feat(connector): added payment flows code

029c4b1

awasthi21 dismissed stale reviews from SanchithHegde, SamraatBansal, and AkshayaFoiger via 029c4b1 July 11, 2024 10:25

awasthi21 force-pushed the 5027-datatrans-connector-integration branch from dd2b801 to 029c4b1 Compare July 11, 2024 10:25

SamraatBansal approved these changes Jul 11, 2024

View reviewed changes

SanchithHegde approved these changes Jul 11, 2024

View reviewed changes

sai-harsha-vardhan approved these changes Jul 12, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Jul 12, 2024

Merged via the queue into juspay:main with commit f24a407 Jul 12, 2024
11 of 13 checks passed

pixincreate reviewed Jul 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(connector): [DATATRANS] Implement card payments #5028

feat(connector): [DATATRANS] Implement card payments #5028

awasthi21 commented Jun 18, 2024 •

edited

Loading

deepanshu-iiitu commented Jun 20, 2024

deepanshu-iiitu Jun 21, 2024

awasthi21 Jun 21, 2024

deepanshu-iiitu Jun 24, 2024

deepanshu-iiitu Jun 21, 2024

deepanshu-iiitu Jun 21, 2024

awasthi21 Jun 21, 2024

deepanshu-iiitu Jun 21, 2024

deepanshu-iiitu Jun 21, 2024

deepanshu-iiitu Jun 21, 2024

awasthi21 Jun 21, 2024

deepanshu-iiitu Jun 21, 2024

SamraatBansal Jun 30, 2024

deepanshu-iiitu commented Jun 21, 2024

SamraatBansal Jun 26, 2024

SamraatBansal Jun 30, 2024

pixincreate Jul 14, 2024 •

edited

Loading

	if error.message == *"already settled" {
	if error.message == "already settled".to_string() {

	if error.message == *"transaction already canceled" {
	if error.message == "transaction already canceled".to_string() {

feat(connector): [DATATRANS] Implement card payments #5028

feat(connector): [DATATRANS] Implement card payments #5028

Conversation

awasthi21 commented Jun 18, 2024 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

deepanshu-iiitu commented Jun 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deepanshu-iiitu commented Jun 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pixincreate Jul 14, 2024 • edited Loading

Choose a reason for hiding this comment

awasthi21 commented Jun 18, 2024 •

edited

Loading

pixincreate Jul 14, 2024 •

edited

Loading