refactor: introduce ConnectorIntegrationNew and add default implementation for each Connector #4989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation for each Connector
hrithikesh026
added
S-waiting-on-review
Base automatically changed from
introduce-router-data-new-and-flow-specific-data-models
to
main
June 14, 2024 07:20
…mmyConnector inside a different module with dummy_connector feature flag
|
|
||
| use std::{marker::PhantomData, ops::Deref}; | ||
|
|
||
| pub use flow_common_types::*; |
There was a problem hiding this comment.
Nit: Can we avoid the glob imports everywhere (among all new imports added in this PR)?
There was a problem hiding this comment.
Sure.
What is the advantage of doing this?
There was a problem hiding this comment.
The primary reason I'd like not having glob imports is better code navigation. Sure, Ctrl/Cmd + clicking on the type name does take us to the relevant type when we're within the IDE, but if we're quickly checking code outside the IDE, or without rust-analyzer available, such as within the GitHub web UI, finding out where a type is made available from becomes quite difficult.
…ntegration-new-and-add-default-implementation-for-each-connector
…default-implementation-for-each-connector
jarnura
approved these changes
Jun 19, 2024
…default-implementation-for-each-connector
SanchithHegde
approved these changes
Jun 20, 2024
Gnanasundari24
deleted the
introduce-connector-integration-new-and-add-default-implementation-for-each-connector
branch
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Introduced ConnectorIntegrationNew and added default implementation for each Connector using macros
Additional Changes
Motivation and Context
How did you test it?
Checked if code compiles successfully
Checklist
cargo +nightly fmt --allcargo clippy