refactor: separate DB queries and HTML creation for payout links #4967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms + DB queries + transformers add create collect link flow - validate and initiate flow
refactor(diesel_models/generic_link): add distinct queries as per link_type refactor(collect_link): hide sensitive data feat(collect_link): inject dynamic content in collect link and it's status page
… into payout_link Signed-off-by: Chikke Srujan <[email protected]>
SanchithHegde
added
the
M-configuration-changes
SanchithHegde
previously approved these changes
Jun 25, 2024
SanchithHegde
approved these changes
Jun 25, 2024
| @@ -676,7 +676,13 @@ impl Settings<SecuredSecret> { | |||
| .with_list_parse_key("redis.cluster_urls") | |||
| .with_list_parse_key("events.kafka.brokers") | |||
| .with_list_parse_key("connectors.supported.wallets") | |||
| .with_list_parse_key("connector_request_reference_id_config.merchant_ids_send_payment_id_as_connector_request_id"), | |||
| .with_list_parse_key("connector_request_reference_id_config.merchant_ids_send_payment_id_as_connector_request_id") | |||
There was a problem hiding this comment.
This is not scalable: this would not allow us to use any suitable key (any possible enum variant) in the HashMap, but only restricts to the specified keys. We would need to address this in a separate PR.
sahkal
approved these changes
Jun 25, 2024
kashif-m
removed request for
ivor-juspay,
seekshiva,
prajjwalkumar17,
inventvenkat and
lsampras
prajjwalkumar17
approved these changes
Jun 25, 2024
lsampras
approved these changes
Jun 25, 2024
Comment on lines
+15
to
+17
| Payout { | ||
| payout_id: String, | ||
| }, |
There was a problem hiding this comment.
you might need some changes in the api_events.sql in /crates/analytics/src/docs/scripts/clickhouse
Comment on lines
+62
to
+64
| PaymentMethodCollectLink { | ||
| link_id: String, | ||
| }, |
There was a problem hiding this comment.
you might need some changes in the api_events.sql in /crates/analytics/src/docs/scripts/clickhouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds below features
Additional Changes
Motivation and Context
How did you test it?
Tested locally
https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-e9eb1c28-489b-4ada-bd00-57c2b4459dea?action=share&creator=9906252
Screencast.from.14-06-24.01.29.08.PM.IST.webm
Checklist
cargo +nightly fmt --allcargo clippy