Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add logging functionality in drainer #495

Merged
merged 11 commits into from
Feb 3, 2023
Merged

feat: Add logging functionality in drainer #495

merged 11 commits into from
Feb 3, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR configures and adds logging to the drainer crate.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-02-03 at 2 02 51 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-drainer Area: Drainer A-performance Area: Performance optimisation labels Feb 3, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Feb 3, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner February 3, 2023 08:37
Abhicodes-crypto
Abhicodes-crypto approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Feb 3, 2023
@SanchithHegde SanchithHegde merged commit 7d8f100 into main Feb 3, 2023
@SanchithHegde SanchithHegde deleted the logs-drainer branch February 3, 2023 09:31
@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement and removed S-ready-to-merge labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-drainer Area: Drainer A-framework Area: Framework A-performance Area: Performance optimisation C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NishantJoshi00 @jarnura @SanchithHegde @Abhicodes-crypto