Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): [Worldline] cards audit fix #4886

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

AkshayaFoiger
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR
1.Handles 2xx and 4xx error
2. Extends manual capture for bank redirects
3. Adds validation based on for capture amount
4. Adds Revolut as a issuer bank
5. Mandates required fields for bank redirects

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner June 5, 2024 10:38
@AkshayaFoiger AkshayaFoiger self-assigned this Jun 5, 2024
@AkshayaFoiger AkshayaFoiger added A-connector-integration Area: Connector integration C-bug Category: Bug labels Jun 5, 2024
@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner June 19, 2024 03:57
@AkshayaFoiger AkshayaFoiger changed the title refactor(connector): [Worldline] authorization request and enhance error handling refactor(connector): [Worldline] cards audit fix Jun 20, 2024
@AkshayaFoiger AkshayaFoiger marked this pull request as draft June 21, 2024 06:14
@AkshayaFoiger AkshayaFoiger marked this pull request as ready for review June 25, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant