Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): FRM Analytics #4880

Merged
merged 41 commits into from
Jul 4, 2024
Merged

feat(analytics): FRM Analytics #4880

merged 41 commits into from
Jul 4, 2024

Conversation

tsdk02
Copy link
Contributor

@tsdk02 tsdk02 commented Jun 5, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added frm dashboard metrics and filters.
Filters based on:

  • frm_status
  • frm_name
  • frm_transaction_type

Metrics calculated:

  • frm_triggered_attempts
  • frm_blocked_rate

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Can get analytics insights based on frm

How did you test it?

Below is the collection for testing :
frms.postman_collection.json

Tested using local data by sending cURL requests through Postman.
Screenshot 2024-06-05 at 11 57 32 AM
Screenshot 2024-06-05 at 11 57 49 AM
Screenshot 2024-06-05 at 11 58 01 AM
Screenshot 2024-06-05 at 11 58 35 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@tsdk02 tsdk02 changed the title Frm analytics feat(analytics): FRM Analytics Jun 5, 2024
@lsampras lsampras linked an issue Jun 5, 2024 that may be closed by this pull request
@lsampras lsampras added A-framework Area: Framework C-feature Category: Feature request or enhancement A-Analytics labels Jun 5, 2024
@tsdk02 tsdk02 changed the title feat(analytics): FRM Analytics feat(analytics): FRM analytics Jun 5, 2024
@tsdk02 tsdk02 changed the title feat(analytics): FRM analytics feat(analytics): FRM Analytics Jun 5, 2024
@ivor-juspay
Copy link
Contributor

ivor-juspay commented Jun 5, 2024

image
all dimensions are null. Is the deserialization to the internal struct happening correctly? Can you share a curl req/ resp with some dimensions in groupByNames clause

@tsdk02
Copy link
Contributor Author

tsdk02 commented Jun 6, 2024

Adding a curl req/ resp with some dimensions in groupByNames clause. It works as expected.
Link to comment: #4880 (comment)
Screenshot 2024-06-06 at 5 05 41 PM

@hyperswitch-bot hyperswitch-bot bot removed the M-database-changes Metadata: This PR involves database schema changes label Jun 26, 2024
ivor-juspay
ivor-juspay previously approved these changes Jun 26, 2024
lsampras
lsampras previously approved these changes Jul 1, 2024
@tsdk02 tsdk02 requested a review from Abhitator216 July 1, 2024 12:44
Abhitator216
Abhitator216 previously approved these changes Jul 2, 2024
@Abhitator216 Abhitator216 dismissed stale reviews from lsampras and themself via 61c86e0 July 2, 2024 07:31
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Jul 2, 2024
@Abhitator216 Abhitator216 self-requested a review July 2, 2024 08:10
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit cc88c07 Jul 4, 2024
11 checks passed
@likhinbopanna likhinbopanna deleted the frm_analytics branch July 4, 2024 07:12
pixincreate pushed a commit that referenced this pull request Jul 4, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: Abhitator216 <[email protected]>
Co-authored-by: Abhishek Kanojia <[email protected]>
Co-authored-by: ivor-juspay <[email protected]>
Co-authored-by: Sampras Lopes <[email protected]>
pixincreate added a commit that referenced this pull request Jul 5, 2024
…ify-cypress

* 'main' of github.com:juspay/hyperswitch: (22 commits)
  refactor: Adding millisecond to Kafka timestamp (#5202)
  chore(version): 2024.07.05.0
  fix(user_auth_method): make id option in auth select (#5213)
  Docs: Updated API - ref for payments (#5172)
  feat(core): add merchant order reference id (#5197)
  feat(analytics): Refund status serialization issue for ckh analytics (#5199)
  fix(router): `override setup_future_usage` filed to on_session based on merchant config (#5195)
  feat(cypress): make tests forcefully skippable (#5176)
  feat(core): Added integrity framework for Authorize and Sync flow with connector as Stripe (#5109)
  ci(cypress): Update card number for adyen and status for paypal (#5192)
  refactor(cypress): error handling and add sync refunds in places where missing (#5128)
  feat(analytics): FRM Analytics (#4880)
  chore(version): 2024.07.04.0
  feat(pm_auth): Added balance check for PM auth bank account (#5054)
  refactor(payment_methods): add appropriate missing logs (#5190)
  refactor(migrations): add commands to make file to run migrations for api v2 (#5169)
  chore(version): 2024.07.03.0
  fix(event): Updated the ApiEventMetric (#5126)
  feat(router): add refunds manual-update api (#5094)
  refactor(payment_link): logs payment links logs coverage (#4918)
  ...
Narayanbhat166 pushed a commit that referenced this pull request Jul 8, 2024
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: Abhitator216 <[email protected]>
Co-authored-by: Abhishek Kanojia <[email protected]>
Co-authored-by: ivor-juspay <[email protected]>
Co-authored-by: Sampras Lopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analytics A-framework Area: Framework C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FRM Analytics
6 participants