feat(auth): Add support for partial-auth, by facilitating injection of authentication parameters in headers #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishantJoshi00
requested review from
jagan-jaya,
jarnura,
Narayanbhat166 and
knutties
NishantJoshi00
added
A-framework
jarnura
requested changes
May 30, 2024
jagan-jaya
requested changes
Jun 13, 2024
Co-authored-by: Jagan <[email protected]>
akshay-97
previously approved these changes
Jul 2, 2024
akshay-97
approved these changes
Jul 5, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adding a wrapper over
ApiKeyAuthandPublishableKeyAuththat provides an alternative to allow authentication being done outside the application. This is done by allowing the external entity (most likely a reverse proxy) to send the parameters necessary for the authentication of the request, there by reducing the need to perform db calls and improving the performance of the service.Additional Changes
Motivation and Context
How did you test it?
Using a dummy service to generate a request and header parameters, and sending this parameter to the hyperswitch application without
api-keyand getting authenticated for the request.Here, you can see that the request was successful, but the payment failed. There by showcasing that the request was authenticated successfully.
Checklist
cargo +nightly fmt --allcargo clippy