Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: minor formatting and logo changes in github README #457

Merged
merged 9 commits into from
Jan 23, 2023
Merged

doc: minor formatting and logo changes in github README #457

merged 9 commits into from
Jan 23, 2023

Conversation

NishantJoshi00
Copy link
Member

updated Belief and values## Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR contains some changes that were indicated by @vimalkumar & @shan-ms in the Github README

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

NishantJoshi00 and others added 4 commits January 22, 2023 21:27
@NishantJoshi00
doc: new logo at the start
041973f
@vimalkumar
Update README.md
4222ca7 
refactored the value prop
@vimalkumar
Update README.md
e654270 
formatting changes
@vimalkumar
Update README.md
8dbad24 
updated Belief and values
@NishantJoshi00 NishantJoshi00 added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 23, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Jan 23, 2023
@NishantJoshi00 NishantJoshi00 requested a review from a team as a code owner January 23, 2023 06:04
jarnura
jarnura previously approved these changes Jan 23, 2023
View reviewed changes
ashokkjag
ashokkjag previously approved these changes Jan 23, 2023
View reviewed changes
@SanchithHegde SanchithHegde dismissed stale reviews from ashokkjag and jarnura via 6c8152e January 23, 2023 06:50
@SanchithHegde SanchithHegde merged commit ead568e into main Jan 23, 2023
@SanchithHegde SanchithHegde deleted the experimental-readme branch January 23, 2023 09:11
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag ashokkjag approved these changes

@NarsGNA NarsGNA NarsGNA approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

@shan-ms shan-ms Awaiting requested review from shan-ms

@bernard-eugine bernard-eugine Awaiting requested review from bernard-eugine

Assignees

@NishantJoshi00 NishantJoshi00

Labels
C-doc Category: Documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@NishantJoshi00 @jarnura @ashokkjag @NarsGNA @SanchithHegde @vimalkumar