fix(euclid_wasm): checkout wasm metadata issue #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
previously approved these changes
Mar 26, 2024
Comment on lines
312
to
331
| let mcc = match response.metadata.clone() { | ||
| Some(meta_data) => meta_data.mcc, | ||
| _ => None, | ||
| }; | ||
| let merchant_country_code = match response.metadata.clone() { | ||
| Some(meta_data) => meta_data.merchant_country_code, | ||
| _ => None, | ||
| }; | ||
| let merchant_name = match response.metadata.clone() { | ||
| Some(meta_data) => meta_data.merchant_name, | ||
| _ => None, | ||
| }; | ||
| let acquirer_bin = match response.metadata.clone() { | ||
| Some(meta_data) => meta_data.acquirer_bin, | ||
| _ => None, | ||
| }; | ||
| let acquirer_merchant_id = match response.metadata.clone() { | ||
| Some(meta_data) => meta_data.acquirer_merchant_id, | ||
| _ => None, | ||
| }; |
There was a problem hiding this comment.
Don't clone metadata multiple times. Instead clone once and try to use the cloned object
…hyperswitch into fix-checkout-wasm-metadata-issue
ArjunKarthik
previously approved these changes
Mar 26, 2024
sai-harsha-vardhan
approved these changes
Mar 26, 2024
ArjunKarthik
approved these changes
Mar 26, 2024
pixincreate
added a commit
that referenced
this pull request
Apr 1, 2024
* 'main' of github.com:juspay/hyperswitch: refactor(core): removed the processing status for payment_method_status (#4213) docs(README): remove link to outdated early access form build(deps): bump `error-stack` from version `0.3.1` to `0.4.1` (#4188) chore(version): 2024.04.01.0 feat(mandates): allow off-session payments using `payment_method_id` (#4132) ci(CI-pr): determine modified crates more deterministically (#4233) chore(config): add billwerk base URL in deployment configs (#4243) feat(payment_method): API to list countries and currencies supported by a country and payment method type (#4126) chore(version): 2024.03.28.0 refactor(config): allow wildcard origin for development and Docker Compose setups (#4231) fix(core): Amount capturable remain same for `processing` status in capture (#4229) fix(euclid_wasm): checkout wasm metadata issue (#4198) fix(trustpay): [Trustpay] Add error code mapping '800.100.100' (#4224) feat(connector): [billwerk] add connector template code (#4123) fix(connectors): fix wallet token deserialization error (#4133) fix(log): adding span metadata to `tokio` spawned futures (#4118) chore(version): 2024.03.27.0 fix(connector): [CRYPTOPAY] Skip metadata serialization if none (#4205) fix(connector): [Trustpay] fix deserialization error for incoming webhook response for trustpay and add error code mapping '800.100.203' (#4199) fix(core): make eci in AuthenticationData optional (#4187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Screen.Recording.2024-03-26.at.2.49.38.PM.mov
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy