Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address Rust 1.77 clippy lints #4172

Merged
merged 3 commits into from
Mar 22, 2024
Merged

chore: address Rust 1.77 clippy lints #4172

merged 3 commits into from
Mar 22, 2024

Conversation

Chethan-rao
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR addresses the clippy lints occurring due to new rust version 1.77

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Chethan-rao Chethan-rao added the C-refactor Category: Refactor label Mar 21, 2024
@Chethan-rao Chethan-rao added this to the March 2024 milestone Mar 21, 2024
@Chethan-rao Chethan-rao self-assigned this Mar 21, 2024
@Chethan-rao Chethan-rao requested review from a team as code owners March 21, 2024 18:15
@Chethan-rao Chethan-rao linked an issue Mar 21, 2024 that may be closed by this pull request
chore: address Rust 1.77 clippy lints #4171
Closed
SanchithHegde
SanchithHegde previously approved these changes Mar 21, 2024
View reviewed changes
@Chethan-rao Chethan-rao requested a review from a team as a code owner March 21, 2024 18:42
srujanchikke
srujanchikke approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed connector code.

@pixincreate
Copy link
Member

Basic verification of features (sanity test) should be good to go.

@pixincreate pixincreate added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit f213c51 Mar 22, 2024
10 of 12 checks passed
@pixincreate pixincreate deleted the update-rust-1.77 branch March 22, 2024 13:07
pixincreate pushed a commit that referenced this pull request Mar 25, 2024
@Chethan-rao @hyperswitch-bot
@srujanchikke @pixincreate
chore: address Rust 1.77 clippy lints (#4172)
b282365 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: chikke srujan <[email protected]>
pixincreate pushed a commit that referenced this pull request Mar 25, 2024
@Chethan-rao @hyperswitch-bot
@srujanchikke @pixincreate
chore: address Rust 1.77 clippy lints (#4172)
4ebb71e 
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: chikke srujan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsampras lsampras lsampras approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@Chethan-rao Chethan-rao

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
March 2024 Release
Development

Successfully merging this pull request may close these issues.

chore: address Rust 1.77 clippy lints
5 participants
@Chethan-rao @pixincreate @lsampras @SanchithHegde @srujanchikke