Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): handle redirection to return_url from nested iframe in separate 3ds flow #4164

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

handle redirection to return_url from nested iframe in separate 3ds flow

Currently, we are opening bank page in nested iframe in SDK. So, the redirection post message should be sent to top level instead of immediate parent.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Sanity Separate 3ds flow testing, redirecting properly to return_url of merchant

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-bug Category: Bug labels Mar 21, 2024
@sai-harsha-vardhan sai-harsha-vardhan added this to the March 2024 milestone Mar 21, 2024
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Mar 21, 2024
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner March 21, 2024 08:31
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit b8c9275 Mar 21, 2024
12 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the handle-nested-iframe-3ds-redirection-flow branch March 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants