Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(postman): fix nmi and paypal collection #4129

Merged
merged 1 commit into from
Mar 21, 2024
Merged

ci(postman): fix nmi and paypal collection #4129

merged 1 commit into from
Mar 21, 2024

Conversation

pixincreate
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

touched 2 collections namely, NMI and PayPal:

  • fixed assertion in PayPal which broke due to this commit
  • removed mandate collection from NMI as it is not supported

closes #4127

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Reduce reds.

How did you test it?

  • NMI
    image

  • PayPal
    image

.json files are auto-generate from dir

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Mar 19, 2024
@pixincreate pixincreate added this to the March 2024 milestone Mar 19, 2024
@pixincreate pixincreate self-assigned this Mar 19, 2024
@pixincreate pixincreate requested a review from a team as a code owner March 19, 2024 11:03
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 4fb7c6e Mar 21, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the fix-collections branch March 21, 2024 08:14
@pixincreate pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@likhinbopanna likhinbopanna likhinbopanna approved these changes

Assignees

@pixincreate pixincreate

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
March 2024 Release
Development

Successfully merging this pull request may close these issues.

remove mandates from nmi collection and fix assertions in paypal
4 participants
@pixincreate @SanchithHegde @Gnanasundari24 @likhinbopanna