Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(payment_method_data): add a trait to retrieve billing from payment method data #4095

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented Mar 15, 2024

Type of Change

  • Refactoring

Description

This PR adds a trait to extract billing detials from payment method data. No logical changes that affect payment flows are present in this PR.

Motivation and Context

This change will be used in further PRs to consume payment method data billing and unify it and send it to the connector module.

Impact

Only code changes, no flows are affected

How did you test it?

  • I have added unit tests
Screenshot 2024-03-15 at 11 00 17 AM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Narayanbhat166 Narayanbhat166 added the A-core Area: Core flows label Mar 15, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this Mar 15, 2024
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner March 15, 2024 05:31
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@hrithikesh026 hrithikesh026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 9b9bce8 Mar 20, 2024
13 of 15 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 4505-refactor-add-backwards-compatible-payment_method_data-billing branch March 20, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants