Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deserialization): error message is different when invalid data is passed for payment method data #4022

Merged
merged 9 commits into from
Mar 8, 2024
Merged

fix(deserialization): error message is different when invalid data is passed for payment method data #4022

merged 9 commits into from
Mar 8, 2024

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented Mar 8, 2024 •
edited
Loading

Type of Change

  • Bugfix

Description

If any invalid payment method data is passed, the error we received was wrong. This PR fixes it. More context can be found in the linked issue.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

  • Postman and unit test cases.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Narayanbhat166 Narayanbhat166 added the C-bug Category: Bug label Mar 8, 2024
@Narayanbhat166 Narayanbhat166 added this to the March 2024 milestone Mar 8, 2024
@Narayanbhat166 Narayanbhat166 self-assigned this Mar 8, 2024
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner March 8, 2024 12:24
@Narayanbhat166 Narayanbhat166 linked an issue Mar 8, 2024 that may be closed by this pull request
[BUG] : error message is different when invalid data is passed for payment_method_data #4021
Closed
2 tasks
SanchithHegde
SanchithHegde previously approved these changes Mar 8, 2024
View reviewed changes
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit f1fe295 Mar 8, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the 4021-bug-error-message-is-different-when-invalid-data-is-passed-for-payment_method_data branch March 8, 2024 20:14
@pixincreate
Copy link
Member

I feel like the postman tests should have been moved to Variation Test Cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

Assignees

@Narayanbhat166 Narayanbhat166

Labels
C-bug Category: Bug
Projects
None yet
Milestone
March 2024 Release
Development

Successfully merging this pull request may close these issues.

[BUG] : error message is different when invalid data is passed for payment_method_data
5 participants
@Narayanbhat166 @pixincreate @SanchithHegde @sai-harsha-vardhan @Gnanasundari24