Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payouts): add payout types in euclid crate #3862

Merged
merged 4 commits into from
Mar 21, 2024
Merged

feat(payouts): add payout types in euclid crate #3862

merged 4 commits into from
Mar 21, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Feb 28, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Note - DM for postman collection

Locally, using HyperSwitch's dashboard.
PR for changes - juspay/hyperswitch-control-center#460

Steps for testing

  • Use the appropriate version of dashboard for testing (source code here)
  • Login to dashboard
  • Configure two payout connectors
  • Head to Workflow -> Payout Routing section
  • Configure Rule based config (payment_method - card -> Adyen; payment_method - bank -> Wise)
  • Activate this config
  • Head to postman collection and run it

Expectations

  • Card payouts should be routed through Adyen
  • Bank payouts should be routed through Wise

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m self-assigned this Feb 28, 2024
@kashif-m kashif-m mentioned this pull request Feb 28, 2024
Closed
@kashif-m kashif-m force-pushed the payout_euclid branch 2 times, most recently from 4e3de25 to 029f182 Compare February 28, 2024 09:59
@kashif-m kashif-m changed the base branch from main to payout_list February 28, 2024 10:00
@kashif-m kashif-m changed the title Payout euclid feat(payouts): add payout types in euclid crate Feb 29, 2024
@kashif-m kashif-m linked an issue Feb 29, 2024 that may be closed by this pull request
[FEATURE] Allow routing configuration for payouts juspay/hyperswitch-control-center#459
Open
2 tasks
@kashif-m kashif-m marked this pull request as ready for review February 29, 2024 13:55
@kashif-m kashif-m requested review from a team as code owners February 29, 2024 13:55
@kashif-m kashif-m changed the base branch from payout_list to main March 6, 2024 08:29
@kashif-m kashif-m removed request for a team March 6, 2024 10:15
@kashif-m kashif-m removed the request for review from a team March 6, 2024 10:15
SanchithHegde
SanchithHegde reviewed Mar 7, 2024
View reviewed changes
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
crates/router/src/routes/app.rs Outdated Show resolved Hide resolved
SanchithHegde
SanchithHegde previously approved these changes Mar 13, 2024
View reviewed changes
Aprabhat19
Aprabhat19 requested changes Mar 19, 2024
View reviewed changes
crates/euclid/src/frontend/dir.rs Outdated Show resolved Hide resolved
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit a151485 Mar 21, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the payout_euclid branch March 21, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aprabhat19 Aprabhat19 Aprabhat19 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@kashif-m kashif-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow routing configuration for payouts
4 participants
@kashif-m @SanchithHegde @Aprabhat19 @Gnanasundari24