Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payouts): implement list and filter APIs #3651

Merged
merged 46 commits into from
Mar 21, 2024
Merged

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Feb 14, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Explained in issue - #3652

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Postman collection - https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-a81197fa-a22b-4ff6-a912-42f6c1187591?action=share&creator=9906252

Steps for testing

  1. Import postman collection
  2. Run the pre-requisites
  3. Create a couple of payouts using different payout methods, currencies and countries for different customers
  4. Test # 1 - list payouts using generic constraints
    • limit
    • start_time
    • end_time
    • customer_id
  5. Test # 2 - list available filters
  6. Test # 3 - filter payouts using available filters
    • currency
    • payout_method
    • payout_type
    • ...

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m force-pushed the payout_list branch 2 times, most recently from cefb51e to 1b0861f Compare February 14, 2024 18:22
@kashif-m kashif-m linked an issue Feb 15, 2024 that may be closed by this pull request
2 tasks
@kashif-m kashif-m mentioned this pull request Feb 15, 2024
Base automatically changed from payout_routing to main February 26, 2024 07:44
@kashif-m kashif-m self-assigned this Feb 26, 2024
@kashif-m kashif-m marked this pull request as ready for review February 29, 2024 06:40
@kashif-m kashif-m requested review from a team as code owners February 29, 2024 06:40
@kashif-m kashif-m requested a review from a team as a code owner February 29, 2024 13:02
@kashif-m kashif-m changed the base branch from main to payout_kv_interface February 29, 2024 13:03
@kashif-m kashif-m removed request for a team February 29, 2024 13:05
Base automatically changed from payout_kv_interface to main March 19, 2024 10:18
@Gnanasundari24 Gnanasundari24 dismissed stale reviews from apoorvdixit88, Narayanbhat166, and sahkal March 19, 2024 10:18

The base branch was changed.

@kashif-m kashif-m requested a review from a team March 21, 2024 08:47
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit fb5f0e6 Mar 21, 2024
19 of 21 checks passed
@Gnanasundari24 Gnanasundari24 deleted the payout_list branch March 21, 2024 09:11
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analytics C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Analytics for payouts
7 participants