Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [BOA/Cybersource] Handle Invalid Api Secret #3485

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

deepanshu-iiitu
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Server was throwing 5XX Error if wrong api_secret was passed during Payment Connector - Create.
This is now handled by throwing InvalidConnectorConfig error.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

https://github.com/juspay/hyperswitch-cloud/issues/3255

How did you test it?

Testing can be done by adding wrong api_secret/api_key/key1 during Payment Connector - Create.

  • If wrong api_secret is added you should get the following error:
    Screenshot 2024-01-30 at 1 01 29 PM

  • If wrong api_key/key1 is added you should get the following error:
    Screenshot 2024-01-30 at 1 02 01 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-bug Category: Bug labels Jan 30, 2024
@deepanshu-iiitu deepanshu-iiitu self-assigned this Jan 30, 2024
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner January 30, 2024 07:50
SamraatBansal
SamraatBansal previously approved these changes Jan 30, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 224c1cf Jan 30, 2024
10 of 12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the cyb-boa-wrong-api-secret-fix branch January 30, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants