Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): allow billing and shipping address update in payments confirm flow #2963

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

allow billing and shipping address update in payments confirm flow

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

  1. Create a payment intent by sending billing / shipping address
    image

  2. Confirm a payment by sending updated billing / shipping address and see if it updates in the response
    image

  3. Check in DB if the address is updated as expected
    image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 23, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Nov 23, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested a review from a team as a code owner November 23, 2023 10:56
@likhinbopanna likhinbopanna added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit 59ef162 Nov 23, 2023
10 of 12 checks passed
@likhinbopanna likhinbopanna deleted the allow-address-update-in-payments-confirm branch November 23, 2023 12:11
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants