Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [stripe] use display impl for expiry date #2359

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Sep 25, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Need to test the apple pay simplified and manual flow for stripe
Curl

"metadata": {
        "apple_pay_combined": {
            "simplified": {
                "session_token_data": {
                    "initiative_context": "sdk-test-app.netlify.app"
                },
                "payment_request_data": {
                    "label": "applepay",
                    "supported_networks": [
                        "visa",
                        "masterCard",
                        "amex",
                        "discover"
                    ],
                    "merchant_capabilities": [
                        "supports3DS"
                    ]
                }
            }
        }
      }

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 25, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner September 25, 2023 08:04
@ShankarSinghC ShankarSinghC self-assigned this Sep 25, 2023
@jagan-jaya jagan-jaya added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 35622af Sep 25, 2023
10 of 12 checks passed
@jagan-jaya jagan-jaya deleted the fix_stripe_apple_pay branch September 25, 2023 10:12
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Bug C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants