Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connector): [Shift4] Fix incorrect deserialization of webhook event type #1463

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix(connector): [Shift4] Fix incorrect deserialization of webhook event type #1463

merged 1 commit into from
Jun 19, 2023

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix webhooks for shift4 . Rename webhooks event type to SCREAMING_SNAKE_CASE.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-06-16 at 8 17 26 PM Screenshot 2023-06-16 at 8 17 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke
fix webhooks shift4
2092a7c 
Signed-off-by: chikke srujan <[email protected]>
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration C-bug Category: Bug R-waiting-on-L1 Review: Waiting on L1 reviewer labels Jun 16, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner June 16, 2023 14:52
@srujanchikke srujanchikke self-assigned this Jun 16, 2023
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 16, 2023
@srujanchikke srujanchikke changed the title fix(connector):[Shift4] Webhooks fix(connector): [Shift4]Fix webhooks Jun 16, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Jun 16, 2023
@SanchithHegde SanchithHegde changed the title fix(connector): [Shift4]Fix webhooks fix(connector): [Shift4] Fix incorrect deserialization of webhook event type Jun 19, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Jun 19, 2023
Merged via the queue into main with commit b44f35d Jun 19, 2023
7 of 8 checks passed
@SanchithHegde SanchithHegde deleted the fix_refund_webhooks branch June 20, 2023 07:16
@pixincreate pixincreate removed the R-waiting-on-L1 Review: Waiting on L1 reviewer label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@srujanchikke srujanchikke

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@srujanchikke @jagan-jaya @ArjunKarthik @SanchithHegde @pixincreate