feat(connector): [Authorizedotnet] Add Wallet support #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
Signed-off-by: chikke srujan <[email protected]>
Signed-off-by: chikke srujan <[email protected]>
SanchithHegde
previously approved these changes
May 21, 2023
jagan-jaya
requested changes
May 24, 2023
| BankAccount(BankAccountDetails), | ||
| Wallet, | ||
| Klarna, |
There was a problem hiding this comment.
why are other PaymentDetails removed? aren't they supported now?
There was a problem hiding this comment.
Other payment methods are not implemented for this connector. They don't support this payment methods
| BankTransfer, | ||
| } | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug)] |
There was a problem hiding this comment.
need both Serialize and Deserialize
| pub cancel_url: Option<String>, | ||
| } | ||
|
|
||
| #[derive(Serialize, Debug, Deserialize)] |
There was a problem hiding this comment.
need both Serialize and Deserialize
There was a problem hiding this comment.
Parent struct uses both deserialize and serialize .
| pub data_value: String, | ||
| } | ||
|
|
||
| #[derive(Serialize, Debug, Deserialize)] |
There was a problem hiding this comment.
need both Serialize and Deserialize
…llets_support_for_authorizedotnet
…llets_support_for_authorizedotnet Signed-off-by: chikke srujan <[email protected]>
SanchithHegde
added
the
S-waiting-on-review
Signed-off-by: chikke srujan <[email protected]>
ArjunKarthik
previously approved these changes
Jul 5, 2023
jagan-jaya
previously approved these changes
Jul 5, 2023
jagan-jaya
added
S-ready-for-merge
and removed
S-waiting-on-review
SanchithHegde
previously approved these changes
Jul 7, 2023
ArjunKarthik
added
the
S-needs-conflict-resolution
…_support_for_authorizedotnet Signed-off-by: chikke srujan <[email protected]>
srujanchikke
dismissed stale reviews from SanchithHegde, ArjunKarthik, and jagan-jaya
via
e4568ab
srujanchikke
removed
the
S-needs-conflict-resolution
SanchithHegde
approved these changes
Jul 14, 2023
jagan-jaya
approved these changes
Jul 14, 2023
ArjunKarthik
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Wallet Support[Paypal, Googlepay and Applepay] for Authorizedotnet
Additional Changes
Motivation and Context
How did you test it?
Note : It takes one day for this connector to update status from Processing to Success.
Google pay
Paypal Redirection
tested unit tests to ensure existing flows
tested airwallex as there is core change which may alter airwallex 3ds payment
Note : Apple pay testing is pending
Checklist
cargo +nightly fmt --allcargo clippy