-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity feature #366
Identity feature #366
Conversation
Thanks for this. Based on a quick look, this will disable all of the Git panel functionality and replace it with this error message if theres no identity set. Now, the username/email is not required till the user starts to commit the information, so disabling the "changed/staged" view, and history view, and the upcoming diff functionality seems heavy for not having a username/email set. My suggestion would be would be to delay this check till the user goes to commit the the information |
Thanks for the feedback @jaipreet-s. Indeed the current approach is disabling the main panel. I'll update it following your suggestion to check once and only once at the first commit attempt. |
That sounds great! I'll also engage @weihwang to have a look at the username/email popup wording/UX. |
@jaipreet-s does it look better? |
This is a great idea! Do these changes to .git/config migrate upon push? |
@fcollonval This looks great. Looks like there is one merge conflict and an unrelated Travis CI failure though |
@jaipreet-s I finally overcome the CI error. Could you please have a look? |
Fixes #351 and will imply simplification in #345.
User changes
If the user has no
user.name
and nouser.email
defined in Git global configuration, the GitPanel will be replaced by a warning and a button prompting the user for a name and an email.If the user provides them, they will be added as global configuration options in git. Then the extension will behave as previously.
Note;
Backward incompatibilities
None