[MRG] Add refresh token to auth_state if it is available #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
commented
Feb 6, 2018
| @@ -134,6 +135,7 @@ def authenticate(self, handler, data=None): | |||
| 'name': resp_json.get(self.username_key), | |||
| 'auth_state': { | |||
| 'access_token': access_token, | |||
| 'refresh_token': refresh_token, | |||
There was a problem hiding this comment.
do you prefer the key to always be present (like this) but with None as value or only put the key in if the value is not None? I am easy either way.
|
There is a whole collection of errors like this: _______________________ ERROR at teardown of test_auth0 ________________________
def _close():
io_loop.clear_current()
> if (not tornado.ioloop.IOLoop.initialized() or
io_loop is not tornado.ioloop.IOLoop.instance()):
E AttributeError: type object 'IOLoop' has no attribute 'initialized'
../../../virtualenv/python3.6.3/lib/python3.6/site-packages/pytest_tornado/plugin.py:136: AttributeErrorAny ideas what could be causing this? Recent update to tornado? |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the OAuth2 server sends a refresh token, add it to the
auth_state.