Update to JupyterLab 4.3.0rc0

[jtpio]

Update to the latest pre-releases:

• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0a2
• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0b0
• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0b1
• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0b2
• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0b3
• https://github.com/jupyterlab/jupyterlab/releases/tag/v4.3.0rc0

Part of #7441

[github-actions]

👈 Launch a Binder on branch jtpio/notebook/update-lab

[jtpio]

bot please update playwright snapshots

[jtpio]

Looks like the following error might be relevant:

Also need to check the effects of jupyterlab/jupyterlab#16446 on Notebook.

[jtpio]

Looks like the following error might be relevant:

Just noticed an upstream change that might be relevant: jupyterlab/jupyterlab#16523

cc @krassowski who may know more about this. Wondering if this is because we had to fetch the docmanager settings manually at some point due to some race conditions:

notebook/packages/application-extension/src/index.ts

Lines 223 to 246 in 43b8cce

	// Explicitly get the default viewers from the settings because
	// JupyterLab might not have had the time to load the settings yet (race condition)
	// Relevant code: https://github.com/jupyterlab/jupyterlab/blob/d56ff811f39b3c10c6d8b6eb27a94624b753eb53/packages/docmanager-extension/src/index.tsx#L265-L293
	if (settingRegistry) {
	const settings = await settingRegistry.load(
	JUPYTERLAB_DOCMANAGER_PLUGIN_ID
	);
	const defaultViewers = settings.get('defaultViewers').composite as {
	[ft: string]: string;
	};
	// get the file types for the path
	const types = docRegistry.getFileTypesForPath(path);
	// for each file type, check if there is a default viewer and if it
	// is available in the docRegistry. If it is the case, use it as the
	// default factory
	types.forEach((ft) => {
	if (
	defaultViewers[ft.name] !== undefined &&
	docRegistry.getWidgetFactory(defaultViewers[ft.name])
	) {
	defaultFactory = defaultViewers[ft.name];
	}
	});
	}

[krassowski]

Nothing jumps at me here, but some ideas:

• does adding notebook needs to wait on await settingRegistry.ready // @ts-ignore help?
• does it make sense to wrap most of the code in settings.changed(() => { /* register if not registered */ })?

[jtpio]

The error seems to be coming from here in JupyterLab:

https://github.com/jupyterlab/jupyterlab/blob/7bae8e3238967a0a776028150b49a4903759bc90/packages/docmanager-extension/src/index.tsx#L337

[krassowski]

Also seeing this on #7447. I do not think this is 4.3.x specific issue

[krassowski]

The error is coming from here:

https://github.com/jupyterlab/jupyterlab/blob/7bae8e3238967a0a776028150b49a4903759bc90/packages/docmanager-extension/src/index.tsx#L276-L282

settings.get('defaultViewers').composite is undefined, hence Object.keys(defaultViewers) throws.

In fact all settings accessed in onSettingsUpdated there are undefined. And this is the initial call to onSettingsUpdated after application was restored.

[krassowski]

And that code is referenced in Notebook codebase here:

notebook/packages/application-extension/src/index.ts

Lines 223 to 232 in 43b8cce

	// Explicitly get the default viewers from the settings because
	// JupyterLab might not have had the time to load the settings yet (race condition)
	// Relevant code: https://github.com/jupyterlab/jupyterlab/blob/d56ff811f39b3c10c6d8b6eb27a94624b753eb53/packages/docmanager-extension/src/index.tsx#L265-L293
	if (settingRegistry) {
	const settings = await settingRegistry.load(
	JUPYTERLAB_DOCMANAGER_PLUGIN_ID
	);
	const defaultViewers = settings.get('defaultViewers').composite as {
	[ft: string]: string;
	};

Maybe there is no race condition but the settings for docmanager plugin are only loaded but not transformed yet. I guess that the issue in JupyterLab is masked by the fact that app.restored is fired much later.

[krassowski]

I see the same error on released Jupyter Notebook 7.2.0 using https://gist.github.com/jtpio/befb8ebf2b630b4748e2538f79877022

I now think this should not be a blocker for merging this one as there is no regression in JupyterLab 4.3 nor 4.2.x as this was just overlooked previously.

[jtpio]

Thanks @krassowski for looking into this 👍

I guess we could just ignore this for now then.

Spinning back a dev install for this branch, it looks like there is still an issue with the background color though:

[krassowski]

an issue with the background color

Does body or other container need to get .jp-ThemedContainer (ref: https://jupyterlab.readthedocs.io/en/latest/extension/extension_migration.html#css-styling / jupyterlab/jupyterlab#16519)?

[jtpio]

Done in 40387bb.

Although not seeing any change for now:

[jtpio]

Is there a way to reduce the size of the "File size" column? I guess it's related to jupyterlab/jupyterlab#16646 ?

[jtpio]

Although not seeing any change for now:

This change of background color is also picked up in the UI tests, so it's not a local dev environment issue only:

[jtpio]

This change of background color is also picked up in the UI tests, so it's not a local dev environment issue only:

It looks like .jp-ThemedContainer was taking precedence over the custom rule defined here in Notebook:

notebook/packages/application/style/base.css

Line 16 in 43b8cce

background: var(--jp-layout-color2);

[jtpio]

Arf, looks like there are more CSS regressions to fix, for example the menus are now gray and there is no styling on hover:

[jtpio]

bot please update playwright snapshots

[jtpio]

bot please update playwright snapshots

[jtpio]

Arf, it looks like the file browser columns sizes are still a bit unpredictable? Which seems to be introducing flakiness to the UI tests:

filebrowser-flakiness.webm

[jtpio]

For example a first load of the page would give the following:

The next page reload:

[jtpio]

@krassowski @JasonWeill is there something we are missing here to get consistent and predictable widths for the different file browser columns?

[jtpio]

So JupyterLab sets some defaults here:

https://github.com/jupyterlab/jupyterlab/blob/c321c27b50431fc0414b20a3b61375af7ccb6c2e/packages/filebrowser/style/base.css#L173-L186

But the file browser columns appear to have the width style set on page load anyway:

[jtpio]

OK giving up for now on the file browser thing. Will open a separate issue to track it.

So we can finally get this one in a pre-release!