Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise pyppeteer requirement to >=1,<1.1 #1711

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Raise pyppeteer requirement to >=1,<1.1 #1711

merged 1 commit into from
Jan 26, 2022

Conversation

SylvainCorlay
Copy link
Member

Fixes #1707.

@bollwyvl
Copy link
Contributor

Cool. I think this is ready to go, too: conda-forge/pyppeteer-feedstock#11

@SylvainCorlay
Copy link
Member Author

I was about to tag a patch release including the DOM fixes in the lab template. What do you think about that one?

@bollwyvl
Copy link
Contributor

...though i do think this would prompt at least a 6.5.0 release...

@bollwyvl
Copy link
Contributor

i mean, i guess it's an extra... so maybe patch ok?

@SylvainCorlay
Copy link
Member Author

...though i do think this would prompt at least a 6.5.0 release...
i mean, i guess it's an extra... so maybe patch ok?

exactly what I was wondering.

@SylvainCorlay
Copy link
Member Author

I pushed 6.4.1 out with the minuor fixes, and merging this one now to be published with 6.5.0.

@SylvainCorlay SylvainCorlay merged commit a07234f into jupyter:main Jan 26, 2022
@SylvainCorlay SylvainCorlay deleted the pyppeteer-version branch January 26, 2022 21:55
@SylvainCorlay SylvainCorlay added this to the 6.5 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5
Development

Successfully merging this pull request may close these issues.

evaluate upgrading to pyppeteer 1.x
2 participants
@SylvainCorlay @bollwyvl