-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast git #937
Fast git #937
Conversation
When using many plugins, vim-plug may spawn many git processes for them. * get revision * get branch * get remote.origin.url This is too heavy. especially on Windows. This change get revision, branch, remote origin url directly from .git directory. This idea is borrowed from @k-takata's commit for minpac. Executing external programs is slow especially on Windows. Read the information directly from .git directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #690 will be solved by this PR.
@mattn CI seems failed. Can you fix it? |
As far as I can see the output of travis CI, it seems a problem of tester. |
Oh, OK. |
There are failing test cases. Look for |
@junegunn One of tests passed successfully. But others are timed-out. (over 10min) |
Anyway, I just finished fixing problems now. |
Import a part of changes from junegunn/vim-plug#937 by @mattn.
Import a part of changes from junegunn/vim-plug#937 by @mattn. When a user checked out a tag, the `HEAD` file may directly contain the commit ID.
Tests are passing only with vim-nightly. Looks like your code uses features that are not available on older Vim versions (for example, there is no Also, we don't use |
ok. will fix tonight |
Fixed |
Thanks, but as you can see, tests are not passing. You can run the tests locally with Test hangs here with |
Can I make sure where test hangs from CI output? |
Unfortunately, no. Vader prints the report only after the whole test is finished. Looks like |
@junegunn Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing now. (s:trim()
is not a replacment for trim()
)
Merged, thanks for your patience. I can definitely feel the difference in the overall performance even though I'm not on Windows. |
Thank you |
When using many plugins, vim-plug spawn many git processes for them.
This is too heavy. especially on Windows. This change get revision, branch,
remote origin url directly from .git directory.
This idea is borrowed from @k-takata's commit for minpac devel branch.
Before
After