-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scs 2.1.1 #149
Scs 2.1.1 #149
Conversation
If you don't mind @juan-pablo-vielma I copied your changes to build.jl, since cherry-picking was not an option |
@juan-pablo-vielma can you have a look at mac failures? |
Ok looks like this is because of the change from "https://github.com/JuliaLinearAlgebra/OpenBLASBuilder/releases/download/v0.3.0-3/build_OpenBLAS.v0.3.0.jl" for the dependencies in SCSBuilder (the error also happens for v2.0.2 with the updated dependencies). What was the reason for that change? |
I changed this since its the official OpenBlasBuilder and JuliaLang/julia#31441 has been merged for |
97bf887
to
20ab29e
Compare
@juan-pablo-vielma could you have a look at mac failures again? for some reason 1.2 works, but 1.0 and 1.1 can't satisfy EDIT: Oh and there are some strange issued on x64 windows as well... |
@kalmarek a small change to the |
Update build.jl
ok, now everything fails ;-) but due to MOI changes; Surprisingly, windows x86 hits different error than linux/macos... I will ask some of the local magicians to have a look at windows x64 in the next week |
Should be resolved by #159. SCS minor version is capped but you cannot cap the patch version. It's only new tests being added, SCS was not broken. |
@blegat I was thinking about capping MOI version in SCS's Project.toml, but you're right that minor version bumps in MOI could brake tests here, so there's nothing we could/should do about it here |
I created another PR to kalmarek:scs-2.1.1 that fixes windows x64 |
Many thanks! Lets see what happens for windows now... |
No description provided.