Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scs 2.1.1 #149

Merged
merged 7 commits into from
Oct 13, 2019
Merged

Scs 2.1.1 #149

merged 7 commits into from
Oct 13, 2019

Conversation

kalmarek
Copy link
Collaborator

No description provided.

@kalmarek
Copy link
Collaborator Author

If you don't mind @juan-pablo-vielma I copied your changes to build.jl, since cherry-picking was not an option

@kalmarek
Copy link
Collaborator Author

@juan-pablo-vielma can you have a look at mac failures?

@juan-pablo-vielma
Copy link
Contributor

Ok looks like this is because of the change from "https://github.com/JuliaLinearAlgebra/OpenBLASBuilder/releases/download/v0.3.0-3/build_OpenBLAS.v0.3.0.jl"
to
"https://github.com/JuliaPackaging/Yggdrasil/releases/download/OpenBLAS-v0.3.5-2/build_OpenBLAS.v0.3.5.jl"

for the dependencies in SCSBuilder (the error also happens for v2.0.2 with the updated dependencies).

What was the reason for that change?

@kalmarek
Copy link
Collaborator Author

I changed this since its the official OpenBlasBuilder and JuliaLang/julia#31441 has been merged for julia-1.2 so i believe it's way to go

@kalmarek kalmarek force-pushed the scs-2.1.1 branch 5 times, most recently from 97bf887 to 20ab29e Compare September 2, 2019 21:50
@kalmarek
Copy link
Collaborator Author

kalmarek commented Sep 2, 2019

@juan-pablo-vielma could you have a look at mac failures again? for some reason 1.2 works, but 1.0 and 1.1 can't satisfy :indirect LibraryProduct...

EDIT: Oh and there are some strange issued on x64 windows as well...

@juan-pablo-vielma
Copy link
Contributor

@kalmarek a small change to the libopenblas64_ rename fixed the issues for OSX.
I created a PR to kalmarek:scs-2.1.1 with the updates.
Unfortunately, Windows is still failing and I do not have good leads on that.

@kalmarek
Copy link
Collaborator Author

ok, now everything fails ;-) but due to MOI changes;
(I guess MOI version should be capped, since it's moving so fast)

Surprisingly, windows x86 hits different error than linux/macos...

I will ask some of the local magicians to have a look at windows x64 in the next week

@blegat
Copy link
Member

blegat commented Oct 11, 2019

ok, now everything fails ;-) but due to MOI changes;
(I guess MOI version should be capped, since it's moving so fast)

Should be resolved by #159. SCS minor version is capped but you cannot cap the patch version. It's only new tests being added, SCS was not broken.

@kalmarek
Copy link
Collaborator Author

@blegat I was thinking about capping MOI version in SCS's Project.toml, but you're right that minor version bumps in MOI could brake tests here, so there's nothing we could/should do about it here

@juan-pablo-vielma
Copy link
Contributor

I created another PR to kalmarek:scs-2.1.1 that fixes windows x64
Not sure what will happen with windows x86

@kalmarek
Copy link
Collaborator Author

Many thanks! Lets see what happens for windows now...

@kalmarek
Copy link
Collaborator Author

@blegat could we merge this and wait for #147 to release as 0.7 ? the other pull is also breaking.

@blegat blegat added this to the v0.7.0 milestone Oct 13, 2019
@blegat blegat merged commit bd8ef05 into jump-dev:master Oct 13, 2019
@blegat
Copy link
Member

blegat commented Oct 13, 2019

could we merge this and wait for #147 to release as 0.7 ?

Sounds good, I created a milestone and added #147 in it to make sure we wait for it for v0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants