Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.6 to CI #60

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Add 1.6 to CI #60

merged 6 commits into from
Nov 13, 2020

Conversation

odow
Copy link
Member

@odow odow commented Nov 12, 2020

A PR to track fixes for 1.6. Tests fail at present.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #60 (3458522) into master (a627628) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          19       19           
  Lines        1344     1344           
=======================================
  Hits         1146     1146           
  Misses        198      198           
Impacted Files Coverage Δ
src/rewrite.jl 90.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a627628...3458522. Read the comment docs.

Julia changes the representation of :(.+) to that :.+ != :(.+)!
@odow
Copy link
Member Author

odow commented Nov 13, 2020

Current failure is caused by: JuliaLang/julia#37065. A fix is proposed: JuliaLang/julia#38250

TODO:

  • [ ] retest when 38250 is merged

Actually, it may just be because we need to define ndims(::DummyBigInt)

@odow
Copy link
Member Author

odow commented Nov 13, 2020

Tests pass on Julia 1.6, but since Github actions are missing allow-failure, I commented out so we can merge and tag a new release. I don't think we need to test nightly permanently.

@blegat
Copy link
Member

blegat commented Nov 13, 2020

I commented out so we can merge and tag a new release. I don't think we need to test nightly permanently.

The good thing is that the different CI runs are in separate checks so we can easily see if only nightly is failing.

test/dummy.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Nov 13, 2020
@blegat blegat merged commit e5614c4 into master Nov 13, 2020
@odow odow deleted the od/fix16 branch November 15, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants