Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more error checking in getNightlyFileName #237

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add more error checking in getNightlyFileName #237

merged 2 commits into from
Apr 29, 2024

Conversation

DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge DilumAluthge marked this pull request as ready for review April 28, 2024 23:57
@DilumAluthge DilumAluthge requested a review from a team as a code owner April 28, 2024 23:57
IanButterworth
IanButterworth approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@IanButterworth IanButterworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks (given I mentioned it on slack)

@DilumAluthge DilumAluthge merged commit a515f9f into master Apr 29, 2024
51 checks passed
@DilumAluthge DilumAluthge deleted the dpa/assumptions branch April 29, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @IanButterworth