Make embeddings asynchronous using temporal #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweep: PR ReviewSweep is currently reviewing your pr... |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 72a8689 in 1 minute and 13 seconds
More details
- Looked at
368lines of code in7files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_5qkRljEnYAhSIlQ0
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/embeddings-to-temporal
branch
from
72a8689
to
8cc62d4
Compare
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 8cc62d4 in 2 minutes and 19 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/workflows/embed_docs.py:7
- Draft comment:
Usingworkflow.unsafe.imports_passed_through()can introduce security risks or unexpected behavior. Ensure this is necessary and consider implementing safeguards if this approach must be used. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_GQqg872RIBzWEsk9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR integrates asynchronous document embedding using Temporal workflows, enhancing performance, scalability, and adding necessary activities, workflows, and client updates.
Key points:
embed_docs.pyactivity for asynchronous document embedding.EmbedDocsWorkflowinagents-api/agents_api/workflows/embed_docs.pyto manage embedding tasks.EmbedDocsWorkflow.proc_mem_context.py.Generated with ❤️ by ellipsis.dev