Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support certificate pinning #61

Merged
merged 6 commits into from
Aug 5, 2023
Merged

feat: support certificate pinning #61

merged 6 commits into from
Aug 5, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Aug 3, 2023

Background

Sometimes, we want to use a self-signed certificate without trusting it in the system. This PR implements Certificate Pinning to solve it.

Checklist

Full changelogs

  • Support juicity-server generate-certchain-hash [cert_file].
  • Support the pinned_certchain_sha256 config item.

Issue reference

Closes #34

Test Result

Normal case:
image

Abnormal case (hash unmatched):
image

@mzz2017 mzz2017 requested a review from a team as a code owner August 3, 2023 14:07
@mzz2017 mzz2017 changed the title feat: support to pin cert chain feat: support certificate pinning Aug 3, 2023
Copy link
Contributor

@juicity-bot juicity-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 5faaa3b into main Aug 5, 2023
28 checks passed
@mzz2017 mzz2017 deleted the feat_pin_cert branch August 5, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

加入自定义CA选项/Add custom CA support
2 participants