Remove unused detect code compiled function #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following comments explains why it was added, and that indeed it is no longer needed, as such. jtv#851 (comment) Note that neither of these 2 cmake modules are for public use, they are internal cmake stuff. Nothing on the outside should use it. This was feedback given by kitware developers.
Revert "remove a use added for a purpose which is gone in the meantime." This reverts commit 7fdd2f8.
|
Thanks again! Loving the small PRs. |
|
for a next PR, would you consider of bumping the minimum required cmake version. This would mean that CMP0074 policy is in, and no need to check on that and to special logic, and as such another 15 lines can be removed from config.cmake |
|
@killerbot242 sure, that's reasonable. I try not to inconvenience people by raising the minimum version too soon, but it's been long enough that I think Ubuntu (as my benchmark example) has released 2 LTS versions that meet it. Could you just include this in the next PR maybe? |
|
ok I will do that, a PR with just the step up, and once that one is merged, the cleanup part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect_code_compiled function is something from the past and is no longer used