Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded include checksymbolexists #872

Merged

Conversation

killerbot242
Copy link
Contributor

nobody is suing the check_symbol_exists function

The following comments explains why it was added, and that indeed it is no longer needed, as such.
jtv#851 (comment)

Note that neither of these 2 cmake modules are for public use, they are internal cmake stuff.
Nothing on the outside should use it. This was feedback given by kitware developers.
Revert "remove a use added for a purpose which is gone in the meantime."

This reverts commit 7fdd2f8.
@jtv
Copy link
Owner

jtv commented Aug 1, 2024

Thanks!

@jtv jtv merged commit fa74ca1 into jtv:master Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants