Fix for timeflipbox minutes-field drag & drop #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a regression that prevented users from setting the minutes field in timeflipboxes using drag & drop when minuteStep was set.
jtsage
added a commit
that referenced
this pull request
Oct 5, 2011
Fix for timeflipbox minutes-field drag & drop
|
whoops, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a regression that was introduced by 272928a, which added minuteStep support for timeflipboxes.
This new feature worked when you used the scroll wheel to change the minute field, but not when you tried to use drag and drop (e.g. on a touch device). Instead of changing to a new value at the end of the drag sequence, the minute field would simply reset to the last-selected minute.
To fix the issue, this commit makes the END_DRAG handler take the minuteStep option into account.