Few configurations and a bug fix #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaderFormat in readme.
|
This is great, thanks so much - I've merged the changes, the only problem I saw was that you are calling incrementField and decrementField with 2 arguments, they were only expecting one. I've updated accordingly, it seems all to be working very well - updated the demo to show the android mode field re-ordering as well. |
|
I'm glad you liked the changes. Sorry about the incrementField and decrementField functions, that was a last minute change. I'll continue helping out, there's still a bug I'm pursuing. |
|
No worries - I look forward to what else you might come up with - I had never considered that re-ordering the boxes would make a lot of sense internationally. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few configuration options, but the main reason for this pull request is to fix a bug of not working typing the day and month values, instead of just clicking the plus and minus buttons.