Fix #15, bold formatting with asterisks (``*'') #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reenables emphasis highlighting for Markdown text that is fenced by asterisks, *like so*. It actually updates the definitions for regions `markdownItalic`, `markdownBold`, `markdownBoldItalic`, and `markdownCode` from @tpope's `markdown.vim` from 2010-05-21 (which I had lying around locally). A quick local test indicates that the patch works as intended, albeit with slight changes in appearance of formatted text: Example -- previous style -- current style *word* -- no formatting -- italic (as planned) _word_ -- italic -- italic **word** -- no formatting -- bold __word__ -- italic -- bold (see below) Formatting double-underscore as bold follows GitHub's style, see https://help.github.com/articles/basic-writing-and-formatting-syntax/ Note: tpope/vim-markdown@a7dbc31 would be the current up-to-date version of the base plugin, but there have been changes to it that look incompatible with the rest of what's here so I'm basing my work on the old version instead.
|
Oh, I just discovered the work in skystrife/vim-flavored-markdown@5f20f1f, making my PR somewhat redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reenables emphasis highlighting for Markdown text that
is fenced by asterisks, like so.
It actually updates the definitions for regions
markdownItalic,markdownBold,markdownBoldItalic, andmarkdownCodefrom @tpope'smarkdown.vimfrom 2010-05-21 (which I had lying around locally).A quick local test indicates that the patch works as intended, albeit
with slight changes in appearance of formatted text:
Example -- previous style -- current style
word -- no formatting -- italic (as planned)
word -- italic -- italic
word -- no formatting -- bold
word -- italic -- bold (see below)
Formatting double-underscore as bold follows GitHub's style, see
https://help.github.com/articles/basic-writing-and-formatting-syntax/
Note: tpope/vim-markdown@a7dbc31 would
be the current up-to-date version of the base plugin, but there have
been changes to it that look incompatible with the rest of what's here
so I'm basing my work on the old version instead.