Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-review: Development changes #1

Merged
merged 10 commits into from
Jun 14, 2021
Merged

Self-review: Development changes #1

merged 10 commits into from
Jun 14, 2021

Commits on Jun 8, 2021

  1. Implement Humus Balance Calculator 

    * Add Controllers, Services and Routes for Humus Balance along with tests
* Implement get_crop method for crops_service + test
    @jsiig
    jsiig committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b12f6b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into development

    @jsiig
    jsiig committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    4d3c3f5 View commit details
    Browse the repository at this point in the history

  3. Add empty line for separation between resourceful routing declaration… 

    …s and routes
    @jsiig
    jsiig committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    f235fbc View commit details
    Browse the repository at this point in the history

  4. Add keys to iterated table cells to get rid of warning

    @jsiig
    jsiig committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    a062308 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Rewrite HumusBalanceService for getting 1 or 1+ balances simultaneously 

    * + spec

Other changes:
* Add pry gem for debugging to Gemfile
* Add and updates comments
    @jsiig
    jsiig committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    765e660 View commit details
    Browse the repository at this point in the history

  2. Use strong parameters

    @jsiig
    jsiig committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    e597a66 View commit details
    Browse the repository at this point in the history

  3. Consistent spec description strings

    @jsiig
    jsiig committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    805ca75 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. First iteration of crop planner frontend: 

    * Add request
* Add types for various things
* Add CSS for HumusBalance component
* Add classNames helper
* Get started with tests for HumusBalance component
* Update snapshots for table
    @jsiig
    jsiig committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    94d8ff1 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Add error handling and states, fix some blunders: 

    * Return 400 instead of 404, as the resource itself is technically found
* Refactor Table component
* Fix and update Jest snapshots
* Add basic test for rendering 3.14
    @jsiig
    jsiig committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    c792d75 View commit details
    Browse the repository at this point in the history

  2. Code cleanup and uniformity

    @jsiig
    jsiig committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    b47245a View commit details
    Browse the repository at this point in the history