Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require punycode with trailing slash #34

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Conversation

imcotton
Copy link
Contributor

@imcotton imcotton commented Oct 8, 2021

Quote from Punycode.js README:

⚠️ Note that userland modules don't hide core modules.
For example, require('punycode') still imports the deprecated core module even if you executed npm install punycode.
Use require('punycode/') to import userland modules rather than core modules.

@domenic
Copy link
Member

domenic commented Oct 8, 2021

I believe this note is no longer true, as you can test by uninstalling punycode and then the tests will fail.

@domenic domenic closed this Oct 8, 2021
@imcotton
Copy link
Contributor Author

imcotton commented Oct 8, 2021

By run:

NODE_PENDING_DEPRECATION=1 npm test | grep DEP

Gives:

[DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.

In Node.js v16

@domenic domenic reopened this Oct 8, 2021
@imcotton

This comment has been minimized.

@domenic domenic merged commit fef6e95 into jsdom:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants