Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rrweb-cssom #3733

Closed
wants to merge 1 commit into from
Closed

Update rrweb-cssom #3733

wants to merge 1 commit into from

Conversation

shybovycha
Copy link

Bump rrweb-cssom to fix nested CSS selectors parser bug.

Found after dependabot tried bumping jsdom to 24.1.0, which in turn bumped rrweb-cssom to 0.7.0, which introduced a bug. It was fixed in jsdom 0.7.1.

The message in our logs is:

SyntaxError: '>textarea[readonly]' is not a valid selector
 ❯ emit node_modules/nwsapi/src/nwsapi.js:576:17
 ❯ _querySelectorAll node_modules/nwsapi/src/nwsapi.js:1528:9
 ❯ Object._querySelector [as first] node_modules/nwsapi/src/nwsapi.js:1437:14
 ❯ HTMLDivElementImpl.querySelector node_modules/jsdom/lib/jsdom/living/nodes/ParentNode-impl.js:69:44
 ❯ HTMLDivElement.querySelector node_modules/jsdom/lib/jsdom/living/generated/Element.js:1094:58
 ❯ Array.Resolver node_modules/nwsapi/src/nwsapi.js:781:17
 ❯ match_assert node_modules/nwsapi/src/nwsapi.js:1364:13
 ❯ Object._matches [as match] node_modules/nwsapi/src/nwsapi.js:1382:16
 ❯ exports.matchesDontThrow node_modules/jsdom/lib/jsdom/living/helpers/selectors.js:29:36
 ❯ matches node_modules/jsdom/lib/jsdom/living/helpers/style-rules.js:172:10

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 12, INDEX_SIZE_ERR: 1, DOMSTRING_SIZE_ERR: 2, HIERARCHY_REQUEST_ERR: 3, WRONG_DOCUMENT_ERR: 4, INVALID_CHARACTER_ERR: 5, NO_DATA_ALLOWED_ERR: 6, NO_MODIFICATION_ALLOWED_ERR: 7, NOT_FOUND_ERR: 8, NOT_SUPPORTED_ERR: 9, INUSE_ATTRIBUTE_ERR: 10, INVALID_STATE_ERR: 11, SYNTAX_ERR: 12, INVALID_MODIFICATION_ERR: 13, NAMESPACE_ERR: 14, INVALID_ACCESS_ERR: 15, VALIDATION_ERR: 16, TYPE_MISMATCH_ERR: 17, SECURITY_ERR: 18, NETWORK_ERR: 19, ABORT_ERR: 20, URL_MISMATCH_ERR: 21, QUOTA_EXCEEDED_ERR: 22, TIMEOUT_ERR: 23, INVALID_NODE_TYPE_ERR: 24, DATA_CLONE_ERR: 25 }
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/12]⎯

Bump rrweb-cssom to fix nested CSS selectors parser bug
@domenic
Copy link
Member

domenic commented Jul 14, 2024

We're already using the ^ operator, so this is unnecessary; any new installs of jsdom will get this by default.

@domenic domenic closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants