Update script that generates allProperties.js #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the output syntax to match the most recent updates
e90e3e0
to
e7fc289
Compare
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
==========================================
+ Coverage 36.07% 36.86% +0.78%
==========================================
Files 86 87 +1
Lines 1156 1172 +16
Branches 218 224 +6
==========================================
+ Hits 417 432 +15
- Misses 632 633 +1
Partials 107 107
Continue to review full report at Codecov.
|
sirian
reviewed
Dec 22, 2019
| @@ -68,13 +68,14 @@ request(url, function(error, response, body) { | |||
| ); | |||
| out_file.write('/*\n *\n * https://www.w3.org/Style/CSS/all-properties.en.html\n */\n\n'); | |||
|
|
|||
| out_file.write('var allProperties = new Set();\n'); | |||
There was a problem hiding this comment.
Maybe it's better to replace with
out_file.write('module.exports = new Set(' + JSON.stringify(CSSpropertyNames.map(camelToDashed), null, 2) + ');\n'P.S. JSON.stringify(foo, null, 2) produces pretty-printed JSON with 2 spaces indent
f4e5175
to
bb2db59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the output syntax to match the most recent updates