Define style object getters/setters for hyphenated CSS properties too #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties in lib/properties/ all have camel-cased names, so that's covered, but getting/setting hyphenated properties ought to work as well.
chad3814
added a commit
that referenced
this pull request
Mar 3, 2014
…10 added dashed properties as well as camelCase ones.
chad3814
added a commit
that referenced
this pull request
Mar 3, 2014
…10 added dashed properties as well as camelCase ones.
chad3814
added a commit
that referenced
this pull request
Mar 3, 2014
…10 added dashed properties as well as camelCase ones. Conflicts: lib/CSSStyleDeclaration.js package.json
|
I've actually gone back and forth about this in my mind a bit. The dashed properties aren't in the css definition, but most browsers accept them. Your PR doesn't lowercase the dashed property, and it doesn't take into consideration the vender-specific properties, which get hyphenated as -webkit-foo-bar and not webkit-foo-bar. I've addressed both of those with the above commits. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties in lib/properties/ all have camel-cased names, so that's covered, but getting/setting hyphenated properties ought to work as well.