rewrote tab function #124
Merged
rewrote tab function #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
old code doesn't work (for me) when I have more than two input. in plus, in old code, "!e.shiftKey" doesn't work because point to the local "eventData" variable "e" and not to the "keydown eventData"
add visibility condition
|
This needs to be merged, I can't believe this PR is a year old. Tab index is still broken on v2.2.5 when you have more than two inputs. Here is a test case using v2.2.4, because the I was just about to submit a PR with my own fix for this issue and found yours. I like that you sorted the tabindex array, I didn't think of that. My version: https://github.com/cnanney/bootstrap-modal/commit/c1462b456711cdb14ae1cc3f403c0e8262de7943 |
|
Sorry this went ignored. Thanks for making the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old code doesn't work (for me) when I have more than two input.
in plus, in old code, "!e.shiftKey" doesn't work because point to the local "eventData" variable "e" and not to the "keydown eventData"