Introduce new field verified_at.
#178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new field will be added next to the current field `verified`, which stores the information if a user has been verified its email address. Internally the new field is used for verification by check the field against `null`. The new field makes it possible to not only store _if_ a user has been verified but also _when_. Closes jrean#177
DariusIII
reviewed
Sep 11, 2018
| @@ -303,7 +306,7 @@ protected function getUserByEmail($email, $table) | |||
| */ | |||
| protected function isVerified($user) | |||
| { | |||
| if ($user->verified == true) { | |||
| if ($user->verified == true && !is_null($user->verified_at)) { | |||
There was a problem hiding this comment.
Maybe use $user->verified_at !== null?
|
@jrean What is the status here? Do you consider to merge this? |
|
@jrean May I ask you why you are closing all these cool (mine and other) PRs without any explanation? |
|
Hi @Konafets If I update and implement it, I will not forget to credit your PR and your work. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new field will be added next to the current field
verified, which stores the information if a user has been verified its email address. Internally the new field is used for verification by check the field againstnull.The new field makes it possible to not only store if a user has been verified but also when.
Closes #177